onPinStateReceive should not update pin value about firmata4j HOT 3 CLOSED

Thanks for reporting that. I'll take a look at this during new year holidays.

from firmata4j.

Thanks for your feedback. I'm currently working on a fix. I'll create a PR.

from firmata4j.

Also, the if

if (pin.getMode() == null) {
    pin.initMode(Pin.Mode.resolve((Byte) event.getBodyItem(PIN_MODE)));
}

is also an a potential issue I think. The device should be the owner of the mode, and if it reports the mode to be something (e.g. INPUT), it should not be filtered. It should probably also triggers the onModeChange event.

This issue will probably only happen if some custom code is added to the physical device (i.e. not StandardFirmata) that changes the pin mode directly. Unlikely to happen, but it could lead to a difficult to investigate issue

from firmata4j.