Code Monkey home page Code Monkey logo

Comments (5)

kullervo16 avatar kullervo16 commented on July 23, 2024

Added the possibility to delete a tag in all checklists, rename it to a new value or merge it into an existing value...

from checklist.

kernixski avatar kernixski commented on July 23, 2024

Tags coming from the template are protected when we try to delete it (the user is not able to delete a tag if this tag is defined in the template or if the tag has been generated based on the directory name or the template name). But the tag management screen bypass this protection. Is this the expected behavior ?

from checklist.

kullervo16 avatar kullervo16 commented on July 23, 2024

Well, the template tag protection is in checklist only, where you normally have a view on a single checklist, you're not concerned with the overall tagging structure of your project

In the tag management screen you do have the view on all tags... if you decide there to delete/rename/merge a template tag, I think we should honor that... so yes, this was intentional.

from checklist.

kernixski avatar kernixski commented on July 23, 2024

It depends how you see your objects. In my point of view, we have checklists and checklists have tags. Checklists have rules. One rule is that we cannot delete the tag with the directory name. Another rule is that we cannot delete the tag with the template name.

The tag management screen manage the tags of the checklists and should follow the checklists rules.

The rules have been added to prevent the user to make "errors". Then I prefer to keep the rules everywhere in the application.

But it is my own point of view. You decide. ;-)

BTW, we should maybe hide this screen in the menu to prevent regular users to access it and to delete tags by mistake.

from checklist.

kullervo16 avatar kullervo16 commented on July 23, 2024

Restricted tag management screen to the admin role (it is visible for all with the listing and the stats, but the edit button/action is restricted).

Also used the logic of #89 to prevent deleting the tag when it originated from a template.

Added some migration code to initialize the originalTemplateTags to the (current) tags of the template so that also the old ones get the tags from the ID (and the tag management screen protection works)

from checklist.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.