Comments (5)
Added the possibility to delete a tag in all checklists, rename it to a new value or merge it into an existing value...
from checklist.
Tags coming from the template are protected when we try to delete it (the user is not able to delete a tag if this tag is defined in the template or if the tag has been generated based on the directory name or the template name). But the tag management screen bypass this protection. Is this the expected behavior ?
from checklist.
Well, the template tag protection is in checklist only, where you normally have a view on a single checklist, you're not concerned with the overall tagging structure of your project
In the tag management screen you do have the view on all tags... if you decide there to delete/rename/merge a template tag, I think we should honor that... so yes, this was intentional.
from checklist.
It depends how you see your objects. In my point of view, we have checklists and checklists have tags. Checklists have rules. One rule is that we cannot delete the tag with the directory name. Another rule is that we cannot delete the tag with the template name.
The tag management screen manage the tags of the checklists and should follow the checklists rules.
The rules have been added to prevent the user to make "errors". Then I prefer to keep the rules everywhere in the application.
But it is my own point of view. You decide. ;-)
BTW, we should maybe hide this screen in the menu to prevent regular users to access it and to delete tags by mistake.
from checklist.
Restricted tag management screen to the admin role (it is visible for all with the listing and the stats, but the edit button/action is restricted).
Also used the logic of #89 to prevent deleting the tag when it originated from a template.
Added some migration code to initialize the originalTemplateTags to the (current) tags of the template so that also the old ones get the tags from the ID (and the tag management screen protection works)
from checklist.
Related Issues (20)
- Tags for the sub-checklists
- Change the way we manage anchors and page scrolling HOT 3
- We should be able to add some task automation when a step is done
- We should be able to specify an expected step status in conditions HOT 1
- Update the templates and the checklist if new deployment
- Use an angular plugin to manage keyboard shortcuts HOT 1
- The ENTER key should apply the "normal" action for the selected step HOT 1
- Conditions should not be returned in the REST representation of the checklists
- A bug allow the user to click on a sub checklist link for a non startable step
- Prevent the HTML templates to be shown
- When we click on the "Go to parent" button, we should add the step in the hash
- When a user make an action on a checklist, we should add a tag with his user id
- Because of Keycloak, pages are shown 2 times. Is it normal ?
- Add a keyboard shortcut to reopen a step
- Focus on edit field in Add Tag window HOT 3
- Options parsing not complete...
- Pages keep refreshing with keycloak 2.5.5.Final HOT 1
- Angular sorting does not like the same tag to be present twice HOT 1
- Add tag does not work anymore in 0.11.2 HOT 1
- Cannot input "R" or backspace key while settings checklist's tag HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from checklist.