Code Monkey home page Code Monkey logo

Comments (3)

kuitos avatar kuitos commented on July 28, 2024

We made this change via #72

BTW which way u used with axios-extensions?
image

If you used it with a script tag, we may need to change the rollup config to transpile it to compatible with es5.

If u used it with a npm way, I think u should make your babel to compile the node_modules and make your dependencies compatible with es5 after bundler build.

from axios-extensions.

ayal avatar ayal commented on July 28, 2024

I use the package with npm.

Of course I can transpile lru-cache myself but I was under the impression that it's bad practice to transpile node_modules + deps, and that the consumer of client-side packages should assume / expect that they are already transpiled and es5 compatible (including their deps).

This was true for axios-extensions until version 3.1.3 and bumping lru-cache version broke this.

from axios-extensions.

krychu90 avatar krychu90 commented on July 28, 2024

+1
I had to downgrade to 3.1.2

from axios-extensions.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.