Code Monkey home page Code Monkey logo

Comments (5)

zhang-li-80 avatar zhang-li-80 commented on May 18, 2024 1

Running version 29.0 (main) as well.

The tap.insertion-filter config issue is my fault.

Found out that the config file wasn't saved

Both the config and the filter.bfl file work.

from kubeshark.

gadotroee avatar gadotroee commented on May 18, 2024

Hi @zhang-li-80

Thanks for the feature idea.

I can suggest two approaches that might be useful for you:

  1. there is option to specify user agents that you want to ignore (health checks are most likely coming from some specific user agent that you can ignore and they will not be inserted at all)
    the way to configure it is using the tap.ignored-user-agents so if you are running mizu tap you can override it like this
    ./mizu tap --set tap.ignored-user-agents=kube-probe [it is array of user agents that will be filtered if the user-agent header includes one of the values [in case you want to disable multiple user agents ./mizu tap --set tap.ignored-user-agents=kube-probe --set tap.ignored-user-agents=monitoring]

  2. the other way to disable insertion of some data that you don't want is to use the insertion filter, so you can configure filter (same syntax in the web ui) and only "passed" items will be inserted.. the way to use this feature -set tap.insertion-filter=http [this will insert only http body] and you can also make it more readable if you want to create file contains your filter and pass the path to the file as value, e.g: -set tap.insertion-filter=filter-file.bfl

I hope it helps and you are more than welcome to suggest more improvements.

from kubeshark.

zhang-li-80 avatar zhang-li-80 commented on May 18, 2024

Thanks for the quick reply.

It looks like the tap.ignored-user-agents works for the health checks.

If I use the tap.insertion-filter to ignore a service, it still gets inserted.

e.g. dst.name != "my-service.k8s".

I have both of them set in the config file.

from kubeshark.

gadotroee avatar gadotroee commented on May 18, 2024

Thanks for letting us know.

I will investigate and check that this option is not broken and try to update here.
Can you just tell me which version are you using?

from kubeshark.

gadotroee avatar gadotroee commented on May 18, 2024

I had a chance to run it myself and I see it is working (in version 29).
the issue might be related to the value you specified in the filter, the easiest way to be sure the filter is correct is to write it inside file and pass this file so you will not have issue with prefix specific characters (like ") [this is at least what happen to me) because the filter need to be dst.name != "my-service.k8s"..

if you can check if via file (e.g create file filter.bfl and write the exact same filter that you wrote and let me know if it solves your problem..

Hope it will and you will be able to start using it - if no, you are more than welcome to write here and I will try to help more

from kubeshark.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.