Code Monkey home page Code Monkey logo

Comments (6)

dwertent avatar dwertent commented on June 10, 2024

Hi @agarcia-oss

Indeed, we haven't finalized our approach for integrating the vulnerability scanning report with the compliance report. From my perspective, this is of lesser priority as the preferred method for scanning images for vulnerabilities is via the kubescape helm chart rather than the CLI. The CLI is primarily intended for providing an overview of capabilities and for gating in CI/CD pipelines. If you intend to continuously scan your cluster, I strongly advise installing the helm chart.

This being said, if adding the report to the CLI is needed we are more than open to suggestions and contributions.

Thoughts?

from kubescape.

agarcia-oss avatar agarcia-oss commented on June 10, 2024

Hi @dwertent thanks for the answer, your suggestion of using the helm chart for image scanning makes perfect sense.

We're considering alternatives, but sure, updating the report with the scan-image information is something we'll be happy to contribute from our side! Just to understand where it could fit, it should be added somewhere in the summaryDetails section, with a new vulnerabilityCounters section?

Thanks in advance!

from kubescape.

dwertent avatar dwertent commented on June 10, 2024

Hi @agarcia-oss, I appreciate your willingness to contribute.

The JSON report is divided into several sections:

  1. summaryDetails: This section provides a summary of the report, including counters.
  2. resources: It consists of a list of all scanned resources.
  3. results: This section contains a combination of resource IDs and the corresponding results for each resource.

We have two options for adding the report:

  1. We can include a section in the base report specifically for the image vulnerabilities report.
  2. Alternatively, we can add a section to the results section. This means that for each resource, we'll include the scanning results.

My suggestion is to add the vulnerability report to the results section. This way, for each resource, we'll have the following structure:

"results": [
        {
            "resourceID": "/kube-system/ServiceAccount/attachdetach-controller/rbac.authorization.k8s.io/v1//ClusterRole/system:controller:attachdetach-controller/rbac.authorization.k8s.io/v1//ClusterRoleBinding/system:controller:attachdetach-controller",
            "controls": [
                   ...
            ],
            "vulnerabilities": [
                   ...
            ]
        }
]

Now, let's focus on a couple of remaining points:

  1. It would be helpful to add counters to the summaryDetails section.
  2. Do we want to support only JSON format, or should we consider other formats as well?

Just something to consider.

from kubescape.

matthyx avatar matthyx commented on June 10, 2024

@agarcia-oss can you help us giving your thoughts on David's questions?

from kubescape.

agarcia-oss avatar agarcia-oss commented on June 10, 2024

Hi @dwertent and @matthyx thanks for the feedback and apologies for not answering earlier.

I think the proposed approach of adding the image scanning results to the results section is great and we'll look into it in the following days. No timeline for this, though.

As for adding the scan results to the rest of the report format, this seems a bit out of scope for us.

Regards!

from kubescape.

dwertent avatar dwertent commented on June 10, 2024

Resolved in release v3.0.4

from kubescape.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.