Comments (6)
I'm not AGAINST trying to find a way to make this work, if someone wants to contribute tests and an implementation.
from git-sync.
I got curl working in quite an annoying and fragile way. but it works. files taken from stock debian bullseye
FROM registry.k8s.io/git-sync/git-sync:v4.2.1
USER root
ADD curl/binary/curl /usr/bin/curl
RUN chmod +x /usr/bin/curl
ADD curl/lib/libcurl.so.4.7.0 /usr/lib/aarch64-linux-gnu/libcurl.so.4
ADD curl/lib/libssl.so.1.1 /usr/lib/aarch64-linux-gnu/libssl.so.1.1
ADD curl/lib/libcrypto.so.1.1 /usr/lib/aarch64-linux-gnu/libcrypto.so.1.1
ADD curl/lib/libldap_r-2.4.so.2.11.5 /usr/lib/aarch64-linux-gnu/libldap_r-2.4.so.2
ADD curl/lib/liblber-2.4.so.2.11.5 /usr/lib/aarch64-linux-gnu/liblber-2.4.so.2
ADD slack.sh /opt/slack.sh
RUN chmod +x /opt/slack.sh
USER git-sync
will play with this a bit more tomorrow
from git-sync.
Alternatively:
- we could offer a non-minimized Dockerfile and you could just build your own from that (meaning a much larger image)
- we could offer a build with curl in it (57.8MB without, 58.9 with - minor)
If we want to include curl, I'd like an e2e test showing it works for some simple things (and doesn't drag in other deps, like git does :) Here's a starting point:
diff --git a/Dockerfile.in b/Dockerfile.in
index dadb69e..18fb5a3 100644
--- a/Dockerfile.in
+++ b/Dockerfile.in
@@ -60,6 +60,7 @@ RUN /stage_binaries.sh -o {ARG_STAGING} \
-p git \
-p openssh-client \
-p ca-certificates \
+ -p curl \
-p socat \
-b /bin/grep \
-b /bin/sed \
from git-sync.
Have exactly the same problems with sending notifications with webhook to slack. The way I managed to install curl into the image is with this
FROM curlimages/curl:8.6.0 AS curl_build
FROM registry.k8s.io/git-sync/git-sync:v4.1.0
USER root
COPY --from=curl_build /usr/bin/curl /usr/bin/curl
COPY --from=curl_build /usr/lib /usr/lib
COPY --from=curl_build /lib /lib
USER git-sync
curl command works, but have not tested it much yet. If I encounter problems, I can let you know
from git-sync.
If someone can help craft an e2e that mimicks a slack integration, I could merge curl. I just want to make sure I don't add curl only to find it is missing some other helper package(s).
from git-sync.
Related Issues (20)
- git-sync with nfs-volume HOT 9
- git-sync v4 no longer supports abbreviated commit SHA HOT 5
- git-sync v4 fetches the HEAD of the remote default branch instead of `master` if --ref is not specified HOT 6
- Sync on tag addition? HOT 11
- Simplify inner loop
- Consider putting the local repo in a subdir of the --root HOT 3
- Wrong path for check of local git hash HOT 3
- Error msg exposes token in URL HOT 4
- GitLab via ssh key HOT 3
- How to disable commit hash in the target folder? HOT 2
- Allow the submodule functionality for repos copied using vcs tool HOT 1
- Temporarily missing files when using $GITSYNC_LINK HOT 4
- Remediate security vulnerabilities on 4.1.0 HOT 5
- High vulnerability CVE-2023-6246 and CVE-2023-6779 HOT 1
- Issue with PYTHONPATH Resolution in git-sync 4.0.0 HOT 2
- exechook behavior HOT 4
- Remediate 4.2.2 security vulnerabilities HOT 1
- Support GitHub App authentication HOT 7
- TODO: infra to make #878 work HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from git-sync.