Code Monkey home page Code Monkey logo

Comments (16)

mrbobbytables avatar mrbobbytables commented on September 13, 2024

Something we should consider when implementing the search functionality is the integration of an alternate search engine for Chinese users.

This is currently being discussed (with bing being the preferred alternative) over in k/website:

kubernetes/website#9635

from contributor-site.

whs-dot-hk avatar whs-dot-hk commented on September 13, 2024

I speak chinese what can I do to help?

from contributor-site.

mrbobbytables avatar mrbobbytables commented on September 13, 2024

@whs-dot-hk Currently, the site does not have search functionality.

The theme currently being used does have an integrated search capability, but it drastically increases page load time =/ and has since been disabled (Long story short, every page winds up loading the entire site...about 4MB of extra content for EVERY page).

Ideally the contributor-site would mimic https://kubernetes.io with an embedded google search. However, embedded google search appears to be blocked in China. The solution being proposed in kubernetes/website#9635 and its associated PR kubernetes/website#9845 is to detect the region and enable using bing search instead.

So, this issue has two big tasks:

  • Replace integrated theme search with google embedded search.
  • Mimic the functionality being developed in k/website to swap search engines based on region.

If you'd like to take a stab at either of those, it'd definitely be appreciated :)

from contributor-site.

fejta-bot avatar fejta-bot commented on September 13, 2024

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

from contributor-site.

castrojo avatar castrojo commented on September 13, 2024

/remove-lifecycle stale

from contributor-site.

fejta-bot avatar fejta-bot commented on September 13, 2024

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

from contributor-site.

mrbobbytables avatar mrbobbytables commented on September 13, 2024

/remove-lifecycle stale

from contributor-site.

fejta-bot avatar fejta-bot commented on September 13, 2024

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

from contributor-site.

mrbobbytables avatar mrbobbytables commented on September 13, 2024

/remove-lifecycle stale

from contributor-site.

nimbinatus avatar nimbinatus commented on September 13, 2024

Thought on this one: Most static site generators can generate a sitemap. If Hugo can generate a JSON sitemap (and I'm pretty sure that such a sitemap could be generated in different languages), a JS search function can search the static file and speed up search and load time. The long timeframe is then offset into the generation time, which the end user won't see.

from contributor-site.

mrbobbytables avatar mrbobbytables commented on September 13, 2024

We had the json sitemap initially, but when we loaded in both the contributor and developer guide it drastically decreased the performance of the site (it was like a 1mb json blob). =/

It'll probably be fine for the interim with the drastically cut down content that we have in there, but might crop up again in the future.

from contributor-site.

nimbinatus avatar nimbinatus commented on September 13, 2024

🤔 Interesting. I wonder why that is. I'll poke around.

from contributor-site.

vishakhanihore avatar vishakhanihore commented on September 13, 2024

/priority important-soon
/kind feature

from contributor-site.

mrbobbytables avatar mrbobbytables commented on September 13, 2024

Follow up to the javascript search --
I went back and looked, it was actually probably because we were ingesting pretty much all of the kubernetes community and enhancement repos. I think it was because that altogether is ALOT of markdown. I think for the content we plan to ingest at this point the javascript search will be fine. 👍

from contributor-site.

mrbobbytables avatar mrbobbytables commented on September 13, 2024

This will be resolved with the migration to docsy. For now I'm going to close this out.

/close

from contributor-site.

k8s-ci-robot avatar k8s-ci-robot commented on September 13, 2024

@mrbobbytables: Closing this issue.

In response to this:

This will be resolved with the migration to docsy. For now I'm going to close this out.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

from contributor-site.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.