Comments (16)
Something we should consider when implementing the search functionality is the integration of an alternate search engine for Chinese users.
This is currently being discussed (with bing being the preferred alternative) over in k/website:
from contributor-site.
I speak chinese what can I do to help?
from contributor-site.
@whs-dot-hk Currently, the site does not have search functionality.
The theme currently being used does have an integrated search capability, but it drastically increases page load time =/ and has since been disabled (Long story short, every page winds up loading the entire site...about 4MB of extra content for EVERY page).
Ideally the contributor-site would mimic https://kubernetes.io with an embedded google search. However, embedded google search appears to be blocked in China. The solution being proposed in kubernetes/website#9635 and its associated PR kubernetes/website#9845 is to detect the region and enable using bing search instead.
So, this issue has two big tasks:
- Replace integrated theme search with google embedded search.
- Mimic the functionality being developed in k/website to swap search engines based on region.
If you'd like to take a stab at either of those, it'd definitely be appreciated :)
from contributor-site.
Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale
.
Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with /close
.
Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale
from contributor-site.
/remove-lifecycle stale
from contributor-site.
Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale
.
Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with /close
.
Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale
from contributor-site.
/remove-lifecycle stale
from contributor-site.
Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale
.
Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with /close
.
Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale
from contributor-site.
/remove-lifecycle stale
from contributor-site.
Thought on this one: Most static site generators can generate a sitemap. If Hugo can generate a JSON sitemap (and I'm pretty sure that such a sitemap could be generated in different languages), a JS search function can search the static file and speed up search and load time. The long timeframe is then offset into the generation time, which the end user won't see.
from contributor-site.
We had the json sitemap initially, but when we loaded in both the contributor and developer guide it drastically decreased the performance of the site (it was like a 1mb json blob). =/
It'll probably be fine for the interim with the drastically cut down content that we have in there, but might crop up again in the future.
from contributor-site.
🤔 Interesting. I wonder why that is. I'll poke around.
from contributor-site.
/priority important-soon
/kind feature
from contributor-site.
Follow up to the javascript search --
I went back and looked, it was actually probably because we were ingesting pretty much all of the kubernetes community and enhancement repos. I think it was because that altogether is ALOT of markdown. I think for the content we plan to ingest at this point the javascript search will be fine. 👍
from contributor-site.
This will be resolved with the migration to docsy. For now I'm going to close this out.
/close
from contributor-site.
@mrbobbytables: Closing this issue.
In response to this:
This will be resolved with the migration to docsy. For now I'm going to close this out.
/close
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
from contributor-site.
Related Issues (20)
- Tracking Issue KCSEU 2024 HOT 6
- Building Kubernetes page is not beginner friendly HOT 5
- Add a SIG API Machinery spotlight article HOT 4
- Broken Link in "First-contribution" Page HOT 9
- Do a spotlight article on SIG Cloud Provider
- Add a SIG Architecture: Code Organisation subproject spotlight article HOT 1
- ./hack/gen-content.sh doesn't work on macOS HOT 6
- Add a SIG Etcd spotlight article HOT 5
- Add a SIG Node spotlight article HOT 1
- Create a shadowing guide for SIG Contribex Comms HOT 4
- Add a SIG Architecture - Enhancements spotlight article HOT 3
- Update X logo to 𝕏 on the website's footer HOT 3
- Tracking Issue KCSNA 2024 HOT 1
- Spotlight: SIG Scheduling HOT 4
- gen-content.sh creates bogus reference links HOT 1
- Link back to contributor-site git repository
- Kubernetes SIG-network meeting not on the Community Calendar. HOT 6
- Steering Spotlight Blog HOT 6
- SIG UI - Spotlight HOT 1
- Add a SIG Scheduling spotlight HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from contributor-site.