Comments (12)
MHBauer
commented on June 15, 2024
I've come to the same conclusion. I'd like to see what you come up with, and if there is any opinion from upstream sig-api.
from apiserver.
pmorie
commented on June 15, 2024
/sig api-machinery
from apiserver.
sttts
commented on June 15, 2024
We are aware of a missing shutdown story. Compare kubernetes/kubernetes#50690 for a try to add that.
Without knowing your code, why can't you call the DestroyFunc manually. After all you have all the plumbing under your control. Compare https://github.com/kubernetes/kubernetes/pull/53586/files#diff-2f720a7e61a4ddfcfe9a9e353be8784bR267 for CRDs.
from apiserver.
MHBauer
commented on June 15, 2024
We can call it, but it has to be threaded fwd and backward and doesn't seem to fully mitigate outstanding threads by the end. Not sure if it requires some time to quiesce.
from apiserver.
MHBauer
commented on June 15, 2024
Maybe we should all be following along in kubernetes/kubernetes#49489 ?
from apiserver.
fejta-bot
commented on June 15, 2024
Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with /close.
Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale
from apiserver.
sttts
commented on June 15, 2024
/remove-lifecycle stale
from apiserver.
n3wscott
commented on June 15, 2024
Thanks, we still are needing to work around this.
from apiserver.
fejta-bot
commented on June 15, 2024
Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with /close.
Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale
from apiserver.
fejta-bot
commented on June 15, 2024
Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
If this issue is safe to close now please do so with /close.
Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten
from apiserver.
fejta-bot
commented on June 15, 2024
Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.
Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close
from apiserver.
k8s-ci-robot
commented on June 15, 2024
@fejta-bot: Closing this issue.
In response to this:
Rotten issues close after 30d of inactivity.
Reopen the issue with/reopen.
Mark the issue as fresh with/remove-lifecycle rotten.Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
from apiserver.
Related Issues (20)
- apiserver fails json patches with 422 when patch body does not match default json.Marshal encoding HOT 4
- unable to get openapi models: OpenAPIV3 config must not be nil HOT 1
- log error about cert expired - does not show important info HOT 8
- Is it possible to disable TLS in apiserver? I would want istio sidecar to terminate TLS. HOT 4
- Update grpc/otelgrpc dependency to fix CVE-2023-47108 HOT 2
- Segfault when kube-client is not specified.
- Invalid Go version in go.mod
- Expose username and group from the appropriate headers HOT 9
- Why exclude resources with errors in the calculation? These errors do not necessarily affect all evaluators HOT 4
- apiserver returns incorrectly results when "Limit" and "LabelSelector" parameters are both set in certain case HOT 7
- Update go-restful module to version >= 3.8.0 due to security issues HOT 5
- OIDC errors HOT 4
- Weird behaviour for remainingItemCount for List HOT 5
- EOL Component HOT 6
- `undefined: unsafe.StringData` on build 1.27-rc.0 with go 1.19 HOT 3
- feature request - audit policy non-resource URL full wildcard support HOT 4
- Query on ContinueToken HOT 8
- Tag v0.28.1 - Issue HOT 6
- Dependency upgrade request - Incompatibility with go.opentelemetry.io/otel version v.1.15.0 and above HOT 5
- New apiserver release that fixes CVE-2023-44487 HOT 5
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from apiserver.