Comments (8)
This problem kinda sucks because the original YAML will have quotes that are not preserved between the conversion of kustomize template->JSON->YAML, and if we desire to keep them, there's no way to indicate to kustomize that they shouldn't be removed. Suppose we start with this YAML kustomize template:
apiVersion: v1
kind: ConfigMap
data:
test1: "${TEMPLATE_VAR1}"
test2: "{TEMPLATE_VAR2}"
test3: "true"
test4: "test4"
metadata:
name: config
When executing kustomize build
, it'll read the kustomization.yaml file and render the manifest. I've narrowed the path down to the JSONToYAML()
function used by the build
command here: https://github.com/kubernetes-sigs/kustomize/blob/33caee50cb25954e1889cea30e3a5b6283e0bfef/api/resource/resource.go#L371
This function is supposed to take a JSON byte array and turns it into valid YAML:
JSON:
{"apiVersion":"v1","data":{"test1":"${TEMPLATE_VAR1}","test2":"{TEMPLATE_VAR2}","test3":"true","test4":"test4"},"kind":"ConfigMap","metadata":{"name":"config"}}
FINAL RESULT
apiVersion: v1
data:
test1: ${TEMPLATE_VAR1}
test2: '{TEMPLATE_VAR2}'
test3: "true"
test4: test4
kind: ConfigMap
metadata:
name: config
My assumption is that any string that isn’t already a valid JSON type (such as a sub structure with {}
or a boolean true
) gets its quotes stripped (You can test the code out in this playground link: https://go.dev/play/p/rFUUlFjPk5f):
from yaml.
Our investigation suggests that the YAML parser is actually doing the "right thing", but the fact that quotes are removed when we explicitly need them, and there appears to be no way to force them to be kept, is very problematic in our use case.
from yaml.
The Kubernetes project currently lacks enough contributors to adequately respond to all issues.
This bot triages un-triaged issues according to the following rules:
- After 90d of inactivity,
lifecycle/stale
is applied - After 30d of inactivity since
lifecycle/stale
was applied,lifecycle/rotten
is applied - After 30d of inactivity since
lifecycle/rotten
was applied, the issue is closed
You can:
- Mark this issue as fresh with
/remove-lifecycle stale
- Close this issue with
/close
- Offer to help out with Issue Triage
Please send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle stale
from yaml.
Related Issues (20)
- Keys with underscores are not parsed correctly. HOT 2
- Time Duration (un)marshalling only translates to nanoseconds HOT 5
- Use 2.3.0 for v2 fork HOT 1
- Possibility to use YAML anchors lost from v1.3.0 to v1.4.0 HOT 4
- Bug: string fields parsed incorrectly in structs nested with `json:",inline"` HOT 1
- CVE-2022-28948: gopkg.in/yaml.v2 HOT 5
- JSONToYAML doesn't preserve map order HOT 2
- Unexpected un-marshal behavior of Bool which is different from its wrapped package HOT 4
- Broken Link Issue HOT 4
- Marshal ignoring `omitempty` for nested structs HOT 1
- feature request: preverse property order HOT 13
- support for "flow" in struct tag HOT 1
- annotations key start with ?character after `yaml.Marshal` HOT 4
- scalars containing colons not properly handled in flow style HOT 4
- Please release fix for CVE-2022-28948 HOT 4
- yaml.Unmarshal HTML escapes input when decoding to json.RawMessage HOT 1
- Related Vulnerabilities fixes HOT 2
- yaml parsing bug HOT 8
- Support `yaml` tags HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from yaml.