Test if driver supports inline volumes in K8s 1.15 about vsphere-csi-driver HOT 20 CLOSED

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

from vsphere-csi-driver.

/assign @SandeepPissay

from vsphere-csi-driver.

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten

from vsphere-csi-driver.

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

from vsphere-csi-driver.

@fejta-bot: Closing this issue.

from vsphere-csi-driver.

Mind if i take this issue? @codenrhoden @SandeepPissay

from vsphere-csi-driver.

Mind if i take this issue? @codenrhoden @SandeepPissay

Sure!

from vsphere-csi-driver.

/assign @Alphasite

from vsphere-csi-driver.

@Alphasite: You can't reopen an issue/PR unless you authored it or you are a collaborator.

from vsphere-csi-driver.

/remove-lifecycle rotten
/reopen

from vsphere-csi-driver.

@Alphasite: You can't reopen an issue/PR unless you authored it or you are a collaborator.

from vsphere-csi-driver.

Ok, looks like this isn't supported in the vsphere-csi; this check fails:

	params.stagingTarget = req.GetStagingTargetPath()
	if params.stagingTarget == "" {
		return nil, status.Error(codes.FailedPrecondition, "Staging Target Path not set")
	}

I need to look a little more deeply into why this is failing, but in the process of digging into this work flow i found this related KEP and PR: kubernetes/enhancements#1698 & kubernetes/kubernetes#92784 which merged literally 2h ago and should provide a more generic implementation of ephemeral inline volumes.

I'll figure out if supporting/testing this current implementation makes sense considering it will soon be superseded.

from vsphere-csi-driver.

@SandeepPissay ^

from vsphere-csi-driver.

@divyenpatel was working on CSI migration and I remember that the inline volumes are supported in CSI. @divyenpatel can you confirm? And can you also send some details on how you tested inline volumes in CSI?

from vsphere-csi-driver.

We have validated the migration of in-line in-tree volume to vSphere CSI Driver.
Refer this - https://gist.github.com/divyenpatel/b06955dccf5944072f742f6bc9e2c59e

In this case, the in-tree inline vSphere volume is presented as in-memory PV to CSI Driver, and thus volume attachment is created using volume path as volume handle.

Spec:
  Attacher:   csi.vsphere.vmware.com
  Node Name:  k8s-node1
  Source:
    Inline Volume Spec:
      Access Modes:
        ReadWriteOnce
      Csi:
        Driver:         csi.vsphere.vmware.com
        Fs Type:        ext4
        Volume Handle:  [vsanDatastore] 0c6ad55e-88c2-e431-bccb-02000359156d/kubernetes-dynamic-pvc-b1b87f44-7f4c-453a-b740-5c307a6a956b.vmdk
      Volume Mode:      Filesystem

We have not validated the CSI inline volume support using FCD ID specified in the pod spec.

from vsphere-csi-driver.

I dont have the testbed anymore, but i ran the k8s ephemeral-inline-volume e2e tests; i think it was this test suite.

I also didn't explicitly specify a volume handle; I also tested manually with a spec similar to:

apiVersion: v1
kind: Pod
metadata:
  name: some-pod
spec:
  containers:
    ...
  volumes:
      - name: vol
        csi:
          driver: inline.storage.kubernetes.io
          volumeAttributes:
              foo: bar

But with the sphere driver. I also enabled ephemeral lifecycle mode, similar to:

apiVersion: storage.k8s.io/v1
kind: CSIDriver
metadata:
  name: mycsidriver.example.com
spec:
...
  volumeLifecycleModes:
  - Persistent
  - Ephemeral

Both manual and the e2e tests failed to create a pod with an inline ephemeral volume.

from vsphere-csi-driver.

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

from vsphere-csi-driver.

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten

from vsphere-csi-driver.

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

from vsphere-csi-driver.

@fejta-bot: Closing this issue.

from vsphere-csi-driver.