Code Monkey home page Code Monkey logo

Comments (9)

listx avatar listx commented on September 22, 2024 1

I just noticed that Mermaidjs diagrams are not working locally. I think updating Hugo might help here.

EDIT: I don't think upgrading Hugo is related to this. This might be an issue related to my local install of Hugo and Docsy. The main reason is because AFAICS both my local and our production version uses Mermaid 9.2.2 and it doesn't make sense that it only fails locally for me when they're on the same version. Just clarifying for the record...

I think the bigger priority is probably getting a containerized version of the build system. The only downside here is that there could be a mismatch between this container and what Netlify uses. I'm not sure what the best practice is here.

from prow.

listx avatar listx commented on September 22, 2024 1

We should probably do something similar to what k/w does wrt grepping the Hugo version so that the container closely matches whatever Netlify uses.

WRT kubernetes/website#34794 I see that they just check in the actual MermaidJS source code directly into a static asset folder. I'm not sure about this (although I don't have strong opinions either way).

from prow.

listx avatar listx commented on September 22, 2024

I've updated some dependencies as part of #35 (notably Docsy to 0.6.0).

Not sure if we need to bump Hugo itself. WDYT @jihoon-seo ?

from prow.

jihoon-seo avatar jihoon-seo commented on September 22, 2024

Like all other dependencies, upgrading Hugo is not a mandatory thing, but seems to be a good thing to do.. 🙂

Notable new features of Hugo v0.101.0:

  • indentation fixes to shortcode blocks
  • resources.Copy function
  • improved error handling

from prow.

jihoon-seo avatar jihoon-seo commented on September 22, 2024

The only downside here is that there could be a mismatch between this container and what Netlify uses. I'm not sure what the best practice is here.

k/w case:

  • Hugo version for Netlify (preview & prod) is configured in netlify.toml, which this repo also has.
  • In Makefile, that Hugo version is extracted from netlify.toml with grep
  • In some Makefile rules that run container, use the extracted Hugo version as a part of container image tag, which in turn is pulled and run.

About Mermaid.js,
there had been issues that Mermaid diagrams were not displayed correctly,
and AFAIK this has been fixed by some PR.
Please see kubernetes/website#34794, and some other issues & PRs if needed.

from prow.

k8s-triage-robot avatar k8s-triage-robot commented on September 22, 2024

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle stale
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

from prow.

k8s-triage-robot avatar k8s-triage-robot commented on September 22, 2024

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle rotten
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

from prow.

k8s-triage-robot avatar k8s-triage-robot commented on September 22, 2024

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Reopen this issue with /reopen
  • Mark this issue as fresh with /remove-lifecycle rotten
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close not-planned

from prow.

k8s-ci-robot avatar k8s-ci-robot commented on September 22, 2024

@k8s-triage-robot: Closing this issue, marking it as "Not Planned".

In response to this:

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Reopen this issue with /reopen
  • Mark this issue as fresh with /remove-lifecycle rotten
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close not-planned

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

from prow.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.