Comments (9)
I just noticed that Mermaidjs diagrams are not working locally. I think updating Hugo might help here.
EDIT: I don't think upgrading Hugo is related to this. This might be an issue related to my local install of Hugo and Docsy. The main reason is because AFAICS both my local and our production version uses Mermaid 9.2.2 and it doesn't make sense that it only fails locally for me when they're on the same version. Just clarifying for the record...
I think the bigger priority is probably getting a containerized version of the build system. The only downside here is that there could be a mismatch between this container and what Netlify uses. I'm not sure what the best practice is here.
from prow.
We should probably do something similar to what k/w does wrt grepping the Hugo version so that the container closely matches whatever Netlify uses.
WRT kubernetes/website#34794 I see that they just check in the actual MermaidJS source code directly into a static asset folder. I'm not sure about this (although I don't have strong opinions either way).
from prow.
I've updated some dependencies as part of #35 (notably Docsy to 0.6.0).
Not sure if we need to bump Hugo itself. WDYT @jihoon-seo ?
from prow.
Like all other dependencies, upgrading Hugo is not a mandatory thing, but seems to be a good thing to do.. 🙂
Notable new features of Hugo v0.101.0:
- indentation fixes to shortcode blocks
resources.Copy
function- improved error handling
from prow.
The only downside here is that there could be a mismatch between this container and what Netlify uses. I'm not sure what the best practice is here.
k/w case:
- Hugo version for Netlify (preview & prod) is configured in
netlify.toml
, which this repo also has. - In
Makefile
, that Hugo version is extracted fromnetlify.toml
withgrep
- In some Makefile rules that run container, use the extracted Hugo version as a part of container image tag, which in turn is pulled and run.
About Mermaid.js,
there had been issues that Mermaid diagrams were not displayed correctly,
and AFAIK this has been fixed by some PR.
Please see kubernetes/website#34794, and some other issues & PRs if needed.
from prow.
The Kubernetes project currently lacks enough contributors to adequately respond to all issues.
This bot triages un-triaged issues according to the following rules:
- After 90d of inactivity,
lifecycle/stale
is applied - After 30d of inactivity since
lifecycle/stale
was applied,lifecycle/rotten
is applied - After 30d of inactivity since
lifecycle/rotten
was applied, the issue is closed
You can:
- Mark this issue as fresh with
/remove-lifecycle stale
- Close this issue with
/close
- Offer to help out with Issue Triage
Please send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle stale
from prow.
The Kubernetes project currently lacks enough active contributors to adequately respond to all issues.
This bot triages un-triaged issues according to the following rules:
- After 90d of inactivity,
lifecycle/stale
is applied - After 30d of inactivity since
lifecycle/stale
was applied,lifecycle/rotten
is applied - After 30d of inactivity since
lifecycle/rotten
was applied, the issue is closed
You can:
- Mark this issue as fresh with
/remove-lifecycle rotten
- Close this issue with
/close
- Offer to help out with Issue Triage
Please send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle rotten
from prow.
The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.
This bot triages issues according to the following rules:
- After 90d of inactivity,
lifecycle/stale
is applied - After 30d of inactivity since
lifecycle/stale
was applied,lifecycle/rotten
is applied - After 30d of inactivity since
lifecycle/rotten
was applied, the issue is closed
You can:
- Reopen this issue with
/reopen
- Mark this issue as fresh with
/remove-lifecycle rotten
- Offer to help out with Issue Triage
Please send feedback to sig-contributor-experience at kubernetes/community.
/close not-planned
from prow.
@k8s-triage-robot: Closing this issue, marking it as "Not Planned".
In response to this:
The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.
This bot triages issues according to the following rules:
- After 90d of inactivity,
lifecycle/stale
is applied- After 30d of inactivity since
lifecycle/stale
was applied,lifecycle/rotten
is applied- After 30d of inactivity since
lifecycle/rotten
was applied, the issue is closedYou can:
- Reopen this issue with
/reopen
- Mark this issue as fresh with
/remove-lifecycle rotten
- Offer to help out with Issue Triage
Please send feedback to sig-contributor-experience at kubernetes/community.
/close not-planned
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
from prow.
Related Issues (20)
- Allow renaming Prow's `test` container for individual jobs HOT 3
- prow: handle the case of re-triggering an expired GitHub workflow
- Prow issue: Bad invalid commit message for npm dependencies #28257 HOT 2
- Allow `ok-to-test` label to approve GitHub workflow runs for new contributors #25210 HOT 3
- Reporting periodic jobs failures to slack channel after number of consequent failures HOT 2
- Prow seems to assign Assignees who are not in OWNERS file HOT 3
- Prow web UI exposes private repositories HOT 5
- plugins: do we still need the `cla` plugin? HOT 2
- [BUG] CC multiple people does not work anymore HOT 13
- Configured Tests Dashboard HOT 1
- Branch protection rules prevent first PR of a merge-batch from being merged
- Crier failing to report OOMed pods HOT 9
- switch to aws-sdk-go-v2 as v1 is going away HOT 1
- Prow issue:
- prow config: where possible, all config should behave like branchprotector for overrides
- Prow issue: HOT 2
- Git providers other than GitHub HOT 1
- Tide re-ran an overridden job HOT 2
- As an unprivileged user, I can write to prow on the server side. HOT 2
- prowjob CRD is too large to apply HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from prow.