Detect kernel config flags about node-feature-discovery HOT 12 CLOSED

A RFC implementation for the non-binary case is found here:
https://github.com/marquiz/node-feature-discovery/tree/feature/kconfig

from node-feature-discovery.

'm' in binary scenario should be treated same as 'y', as this functionality is available in the kernel.
I would suggest to represent it in two variants:

• if 'y' or 'm' -> true, if 'n' -> false
• for config options that are not toggle (yes/module/no), to have sanitation and then use value as is. E.g. we need to check that label's value is value acceptable by k8s API for node selection purposes (no spaces, does not have special characters etc. In k8s APIs it should be validator function for that).

from node-feature-discovery.

This would probably make sense (i.e. mark '=y' and '=m' as true and copy other values as is).

This would make it even possible to implement this in two phases:

1. only support binary labels, check for '=y' and '=m', ignore other values
2. support all kconfig flags

from node-feature-discovery.

PR #146 implements part 1., i.e. support for binary values

from node-feature-discovery.

An implementation of part 2., based on #146 found here:
https://github.com/marquiz/node-feature-discovery/tree/feature/kconfig-all

from node-feature-discovery.

[ I made a similar comment in #140 ]

I just started to think if it would be better to use dot (.) character instead of dash (-) in the label name to separate config option name from the label prefix?? I.e. something like

nfd-kernel-config.NO_HZ
nfd-kernel-config.NO_HZ_IDLE 

Any thoughts?

from node-feature-discovery.

Support for binary labels merged into master in #146

from node-feature-discovery.

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

from node-feature-discovery.

#197 is still open

/remove-lifecycle stale

from node-feature-discovery.

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

from node-feature-discovery.

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten

from node-feature-discovery.

Closing this one-. #197 was merged already a while ago

from node-feature-discovery.