Comments (4)
Thanks @lauralorenz for the clarification. I guess I can help with it.
/assign
from about-api.
sorry, I missed the issue #6, it's probably a duplicate of it
from about-api.
@lauralorenz
It is the issue I mentioned at the community meeting(2022-06-14).
I think the API should be put directly in the module, just like what we did at work-api, which will make it easy to import the API.
If you agree with that, I can help make a change for that. What do you say?
from about-api.
I am also not a go package expert but cross checking with Work API repo, the MCS API repo and the Gateway API repo too I think overall we want go get sigs.k8s.io/about-api
to be the target.
Today I see go get sigs.k8s.io/about-api
does work from a proper redirect perspective but doesn't get all the required files because they are all in clusterproperty which is a subdirectory.
So to achieve parity with these other properly configured repos I agree with @RainbowMango that everything should be put directly in the module (aka everything in the whole about-api/clusterproperty
dir should be unravelled up to the root of the github repo) and then ALSO as OP mentioned the package should be renamed, but to sigs.k8s.io/about-api
.
from about-api.
Related Issues (12)
- Intro tutorials for About API use cases HOT 2
- informer and lister are not generated. HOT 3
- Update with kubebuilder go/v4 HOT 2
- Published CRD yaml file is missing annotation HOT 8
- Update CRD to beta maturity HOT 9
- No such file or directory HOT 7
- Customize kubectl get HOT 2
- Provide standalone CRD yaml HOT 6
- bug: go.mod in subdir presents problems HOT 5
- Remove .spec.name
- Is the current group (about.k8s.io) for clusterproperty API accurate? HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from about-api.