Comments (2)
I hit that too:
# hack/verify-all.sh
Verifying gofmt
No issue found
Verifying govet
go: downloading k8s.io/api v0.18.0
go: downloading k8s.io/kubernetes v1.18.0
go: downloading k8s.io/client-go v0.18.0
go: downloading k8s.io/component-base v0.18.0
go: downloading k8s.io/apiserver v0.18.0
go: downloading k8s.io/cloud-provider v0.18.0
go: downloading k8s.io/kubectl v0.18.0
go: downloading github.com/prometheus/client_golang v1.5.1
go: downloading k8s.io/cri-api v0.18.11-rc.0
go: downloading k8s.io/kube-scheduler v0.18.0
go: downloading k8s.io/csi-translation-lib v0.18.0
Done
Verifying golint
pkg/nfs/controllerserver.go:90:6: `validCapacity` is unused (deadcode)
func validCapacity(requested int64, volumePath string) error {
^
test/e2e/testsuites/testsuites.go:54:2: `pollLongTimeout` is unused (deadcode)
pollLongTimeout = 5 * time.Minute
^
test/e2e/e2e_suite_test.go:23:2: `reportDirEnv` is unused (deadcode)
reportDirEnv = "ARTIFACTS"
^
test/e2e/e2e_suite_test.go:24:2: `defaultReportDir` is unused (deadcode)
defaultReportDir = "test/e2e"
^
pkg/nfs/server.go:94:14: Error return value of `server.Serve` is not checked (errcheck)
server.Serve(listener)
^
cmd/nfsplugin/main.go:37:10: Error return value of `flag.Set` is not checked (errcheck)
flag.Set("logtostderr", "true")
^
cmd/nfsplugin/main.go:42:24: Error return value of `flag.CommandLine.Parse` is not checked (errcheck)
flag.CommandLine.Parse([]string{})
^
cmd/nfsplugin/main.go:55:32: Error return value of `cmd.MarkPersistentFlagRequired` is not checked (errcheck)
cmd.MarkPersistentFlagRequired("nodeid")
^
cmd/nfsplugin/main.go:58:32: Error return value of `cmd.MarkPersistentFlagRequired` is not checked (errcheck)
cmd.MarkPersistentFlagRequired("endpoint")
^
cmd/nfsplugin/main.go:62:16: Error return value of `cmd.ParseFlags` is not checked (errcheck)
cmd.ParseFlags(os.Args[1:])
^
pkg/nfs/controllerserver.go:108:2: var `volumeId` should be `volumeID` (golint)
volumeId := req.GetVolumeId()
^
pkg/nfs/controllerserver.go:345:29: method getVolumeIdFromNfsVol should be getVolumeIDFromNfsVol (golint)
func (cs *ControllerServer) getVolumeIdFromNfsVol(vol *nfsVolume) string {
^
pkg/nfs/controllerserver.go:354:29: method getNfsVolFromId should be getNfsVolFromID (golint)
func (cs *ControllerServer) getNfsVolFromId(id string) (*nfsVolume, error) {
^
pkg/nfs/controllerserver_test.go:19:2: const `testVolumeId` should be `testVolumeID` (golint)
testVolumeId = "test-server/test-base-dir/test-csi"
^
pkg/nfs/nfs.go:55:58: exported func NewNFSdriver returns unexported type *github.com/kubernetes-csi/csi-driver-nfs/pkg/nfs.nfsDriver, which can be annoying to use (golint)
func NewNFSdriver(nodeID, endpoint string, perm *uint32) *nfsDriver {
^
pkg/nfs/nfs.go:85:59: exported func NewNodeServer returns unexported type *github.com/kubernetes-csi/csi-driver-nfs/pkg/nfs.nodeServer, which can be annoying to use (golint)
func NewNodeServer(n *nfsDriver, mounter mount.Interface) *nodeServer {
^
pkg/nfs/nodeserver.go:110:10: `if` block ends with a `return` statement, so drop this `else` and outdent its block (golint)
} else {
^
pkg/nfs/nfs.go:124:2: S1023: redundant `return` statement (gosimple)
return
^
pkg/nfs/server.go:42:2: S1023: redundant `return` statement (gosimple)
return
^
pkg/nfs/controllerserver_test.go:39:3: SA1006: printf-style function with dynamic format string and no further arguments should use print-style function instead (staticcheck)
fmt.Printf(err.Error())
^
pkg/nfs/nodeserver.go:166:6: func `getVolumeMetrics` is unused (unused)
from csi-driver-nfs.
@mayankshah1607 it's done, right?
from csi-driver-nfs.
Related Issues (20)
- Time helm-chart release after image release HOT 5
- VolumeFailedDelete, when i deleted pvc but pv wasn't deleted HOT 9
- dynamic provisioning of existing data HOT 2
- Race condition: terminating pod destroys PV mount on new pod HOT 6
- Pod usage error after pvc mounting HOT 2
- Unable to mount nfs without "nolock" option HOT 2
- Link to MicroK8S Documentation in Readme leads to 404-page
- Please publish Helm Chart to OCI HOT 3
- helm chart volumesnapshot rbac problem HOT 1
- configMap can't mounted as file on the NFS PVC HOT 2
- [Feature Request] Share a PV across namespaces HOT 6
- Warning VolumeResizeFailed pod/pueel-sxx-0 NodeExpandVolume.NodeExpandVolume failed for volume "logging-nfs-pv" : Expander.NodeExpand found CSI plugin kubernetes.io/csi/nfs.csi.k8s.io to not support node expansion HOT 3
- csi-driver-nfs stops working for new PVC on randomly affected nodes. HOT 9
- Documentation for fsGroupPolicy is outdated HOT 1
- Single-node (WIP) cluster can't schedule controller HOT 3
- Failed to pull image "registry.k8s.io/sig-storage/nfsplugin:v4.7.0": rpc error: code = NotFound HOT 2
- wrong chart intent when using multiple mountOptions
- Remount when connection lost HOT 2
- Mounting fails with error "/usr/sbin/start-statd: 10: cannot create /run/rpc.statd.lock: Read-only file system" HOT 7
- pvc pending status Waiting for a volume to be created either by the external provisioner HOT 5
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from csi-driver-nfs.