Code Monkey home page Code Monkey logo

Comments (11)

andyzhangx avatar andyzhangx commented on August 11, 2024

hi @MagicRB would you submit a PR directly? thanks.

from csi-driver-nfs.

andyzhangx avatar andyzhangx commented on August 11, 2024

and you could also contribute how to build this project in NixOS

from csi-driver-nfs.

MagicRB avatar MagicRB commented on August 11, 2024

I really don't want to go through the license agreement stuff, so unfortunately not at this time

from csi-driver-nfs.

andyzhangx avatar andyzhangx commented on August 11, 2024

while I don't have NixOS, not sure how to fix this.

from csi-driver-nfs.

MagicRB avatar MagicRB commented on August 11, 2024

and another issue has cropped up, test/e2e/e2e_suite_test.go:26:2: imported and not used: "strings" which is really an easy fix as the first one. And as to NixOS building, that should really go into nixpkgs, which I'll do at some point.

while I don't have NixOS, not sure how to fix this.

there really only two things, which we can do, either delete that project name check or disable tests as I can't tell Nix to use a different folder, it would break the pureness of the build process.

from csi-driver-nfs.

andyzhangx avatar andyzhangx commented on August 11, 2024

cc @dr0pdb

from csi-driver-nfs.

MagicRB avatar MagicRB commented on August 11, 2024

BTW, I pushed the Docker container builder to my Gitea instance, the builder builds this driver from Nix. It's easy to extract the Nix package from that. The advantage over regular Dockerfiles is truly reproducible builds and (generally) smaller images, seems to not be that pronounced with go apps

from csi-driver-nfs.

fejta-bot avatar fejta-bot commented on August 11, 2024

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle stale

from csi-driver-nfs.

fejta-bot avatar fejta-bot commented on August 11, 2024

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle rotten

from csi-driver-nfs.

fejta-bot avatar fejta-bot commented on August 11, 2024

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-contributor-experience at kubernetes/community.
/close

from csi-driver-nfs.

k8s-ci-robot avatar k8s-ci-robot commented on August 11, 2024

@fejta-bot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-contributor-experience at kubernetes/community.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

from csi-driver-nfs.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.