Code Monkey home page Code Monkey logo

Comments (7)

msau42 avatar msau42 commented on June 24, 2024

/kind failing-test

from csi-driver-host-path.

msau42 avatar msau42 commented on June 24, 2024

@kubernetes-csi/csi-misc

from csi-driver-host-path.

msau42 avatar msau42 commented on June 24, 2024

This is happening in CI too: https://prow.k8s.io/view/gcs/kubernetes-jenkins/logs/ci-kubernetes-csi-1-13-on-kubernetes-1-13/1169142833098002432

from csi-driver-host-path.

msau42 avatar msau42 commented on June 24, 2024

Ok I think it's because in 1.13 logic, we were checking if a directory was a mount point before calling unpublish: https://github.com/kubernetes/kubernetes/blob/release-1.13/pkg/volume/csi/csi_mounter.go#L299

Which I think won't work for hostpath since hostpath is just a bind mount of a directory on the root fs. We removed the logic in 1.14 when implementing ephemeral volumes.

I don't really understand why this isn't failing all the time though (instead of just being flaky).

from csi-driver-host-path.

fejta-bot avatar fejta-bot commented on June 24, 2024

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

from csi-driver-host-path.

msau42 avatar msau42 commented on June 24, 2024

/close
We no longer support 1.13 and 1.14 tests are looking stable

from csi-driver-host-path.

k8s-ci-robot avatar k8s-ci-robot commented on June 24, 2024

@msau42: Closing this issue.

In response to this:

/close
We no longer support 1.13 and 1.14 tests are looking stable

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

from csi-driver-host-path.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.