Code Monkey home page Code Monkey logo

Comments (11)

msau42 avatar msau42 commented on June 24, 2024

/help

from csi-driver-host-path.

k8s-ci-robot avatar k8s-ci-robot commented on June 24, 2024

@msau42:
This request has been marked as needing help from a contributor.

Please ensure the request meets the requirements listed here.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-help command.

In response to this:

/help

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

from csi-driver-host-path.

pohly avatar pohly commented on June 24, 2024

Do we need testing with and without leadership election? Probably yes, because those go through different code paths.

Testing with leadership election isn't going to be very realistic in the Prow CI because it creates a cluster with just one node. We'll execute some additional code paths, but not the actual leadership election. My preference would be to switch to a multi-node KinD cluster for all testing. It's the more realistic case.

from csi-driver-host-path.

pohly avatar pohly commented on June 24, 2024

Maintaining all these different deployments is going to become more complicated. Would it be useful to start generating them with kustomize?

I've done that in PMEM-CSI such that kustomize is only needed when editing the input files. Users and the CI still get complete deployment files. See intel/pmem-csi@6037be5 for details. It wouldn't be hard to move that over to csi-driver-host-path.

from csi-driver-host-path.

msau42 avatar msau42 commented on June 24, 2024

Long term I think a multi-node cluster would be great.

Regarding managing deployment, I'm fine with kustomize. I'm also biased because I use it for PD driver too, and it's been working decently well for testing various configs like alpha, stable, staging, dev

from csi-driver-host-path.

pohly avatar pohly commented on June 24, 2024

@msau42 what about testing with and without leadership election? Do you think we need to test both?

from csi-driver-host-path.

zhucan avatar zhucan commented on June 24, 2024

Why need to add leader election to deployment for csi-driver-host-path? Maybe creating two pod in the same time but in different node

from csi-driver-host-path.

fejta-bot avatar fejta-bot commented on June 24, 2024

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

from csi-driver-host-path.

fejta-bot avatar fejta-bot commented on June 24, 2024

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten

from csi-driver-host-path.

fejta-bot avatar fejta-bot commented on June 24, 2024

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

from csi-driver-host-path.

k8s-ci-robot avatar k8s-ci-robot commented on June 24, 2024

@fejta-bot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

from csi-driver-host-path.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.