Code Monkey home page Code Monkey logo

Comments (13)

sedovalx avatar sedovalx commented on July 23, 2024

The problem happened because I was calling the deploy.sh script from inside the kubernetes-1.17 directory. It should be called from the outside of it.

from csi-driver-host-path.

pohly avatar pohly commented on July 23, 2024

/reopen

It should be possible to invoke the script anywhere. That's what BASE_DIR

BASE_DIR=$(dirname "$0")
is for.

I'm not sure why it is failing, but the issue seems legitimate.

/help

from csi-driver-host-path.

k8s-ci-robot avatar k8s-ci-robot commented on July 23, 2024

@pohly: Reopened this issue.

In response to this:

/reopen

It should be possible to invoke the script anywhere. That's what BASE_DIR

BASE_DIR=$(dirname "$0")
is for.

I'm not sure why it is failing, but the issue seems legitimate.

/help

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

from csi-driver-host-path.

sedovalx avatar sedovalx commented on July 23, 2024

BASE_DIR is . if I do

cd deploy/kubernetes-1.17
./deploy.sh

but it contains kubernetes-1.17 if

./deploy/kubernetes-1.17/deploy.sh

MacOS, zsh

from csi-driver-host-path.

pohly avatar pohly commented on July 23, 2024

Bingo:

driver_version="$(basename "${BASE_DIR}")"

That only works when BASE_DIR includes the "kubernetes-x.yy" name. The check shouldn't make that assumption and instead use
driver_version="$(basename "$(readlink -f "${BASE_DIR}")" )"

Does readlink -f work under MacOS? It's from GNU coreutils.

from csi-driver-host-path.

sedovalx avatar sedovalx commented on July 23, 2024

No, seems it doesn't work on MacOS. Here is an explanation and a workaround https://stackoverflow.com/questions/1055671/how-can-i-get-the-behavior-of-gnus-readlink-f-on-a-mac

from csi-driver-host-path.

pohly avatar pohly commented on July 23, 2024

@sedovalx a simple cd + pwd should do the trick here. Do you think you can come up with a PR?

from csi-driver-host-path.

sedovalx avatar sedovalx commented on July 23, 2024

Sorry - I don't have much knowledge in bash. Can do if you tell me exactly what to change :)

from csi-driver-host-path.

aayushrangwala avatar aayushrangwala commented on July 23, 2024

/cc @pohly

from csi-driver-host-path.

fejta-bot avatar fejta-bot commented on July 23, 2024

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle stale

from csi-driver-host-path.

fejta-bot avatar fejta-bot commented on July 23, 2024

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle rotten

from csi-driver-host-path.

fejta-bot avatar fejta-bot commented on July 23, 2024

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-contributor-experience at kubernetes/community.
/close

from csi-driver-host-path.

k8s-ci-robot avatar k8s-ci-robot commented on July 23, 2024

@fejta-bot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-contributor-experience at kubernetes/community.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

from csi-driver-host-path.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.