Code Monkey home page Code Monkey logo

Comments (6)

codescalar avatar codescalar commented on June 12, 2024

I should also mention that some of the deprecated resources being returned were in fact created using the latest api version (e.g. apps/v1 for Deployments) but are still shown as deprecated (e.g. extensions/v1beta1 for Deployments) by kubepug.

Seems like the same issue related to how kubepug is requesting the resource and how the k8s api server marshalls between api versions depending on the client's request.

from kubepug.

rikatz avatar rikatz commented on June 12, 2024

@codescalar tks for raising this issue!

I'll take a look during this week and the next. The program makes a map of all existing objects in the current swagger and checks which have the 'deprecated' text in their description, trying to get them and so yes, this might happen. Didn't realize that the API could return all of them even if the stable object also exists :)

I'll figure out a way to correlate them and if the object exists both in the stable and the deprecated API remove it from the output :)

Thank you!

from kubepug.

codescalar avatar codescalar commented on June 12, 2024

from kubepug.

rikatz avatar rikatz commented on June 12, 2024

Hey @codescalar 👋

Just passing here to let you know that I didn't forgot about this. I was refactoring the whole thing here to allow input files and then dealing with this also became easier :)

I'll probably solve this next weekend.

Thank you

from kubepug.

codescalar avatar codescalar commented on June 12, 2024

Thanks @rikatz!

from kubepug.

rikatz avatar rikatz commented on June 12, 2024

Well, the guessing here is pretty "hard" as I need to cross between each deprecated object and if it exists in some different API :/

I'm thinking about using the discovery library to feed the API with another struct containing all the preferred names and when something from swagger.json is found, check if there's that same resource name as an stable version.

The final movement is to check if the list length of objects containing the deprecated objects is the same length of the list of objects with the maybe preferred name and assume everything is fine :)

Let me see if this works, will need some testing here because IMO it's worst having a false negative than a false positive in this case :)

from kubepug.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.