Code Monkey home page Code Monkey logo

Comments (6)

ksylvest avatar ksylvest commented on June 12, 2024

@ericbets Sounds like it might be a bug. Can you provide any more detail on reproducing? Also, patches are always loved!

from jquery-gridly.

ksylvest avatar ksylvest commented on June 12, 2024

Closing due to inactivity.

from jquery-gridly.

crystalin avatar crystalin commented on June 12, 2024

What he meant was:
If you put a number of each block (in their initial order). Drag one of them in circle over all of them and drop it, you will get blocks in different order. A nice feature to have would be to keep all the blocks except the one dragged, in order.

from jquery-gridly.

tafuentesc avatar tafuentesc commented on June 12, 2024

I had the same problem trying to implement a drag & drop gallery administration. Looking at the code, I realized the problem was with the Gridly.prototype.compare method:

    Gridly.prototype.compare = function(d, s) {
      if (d.y > s.y + s.h) {
        return +1;
      }
      if (s.y > d.y + d.h) {
        return -1;
      }
      if ((d.x + (d.w / 2)) > (s.x + (s.w / 2))) {
        return +1;
      }
      if ((s.x + (s.w / 2)) > (d.x + (d.w / 2))) {
        return -1;
      }
      return 0;
    };

This rules work great if you do the dragging in a grid-like movement (that is, changing only the column or row in each movement). However, when you place the dragged element in an intermediate position, these rules doens't return the proper order,

Changing the compare function to the following fixed the problem:

    Gridly.prototype.compare = function(d, s) {
      // Case 1: d is bellow s => d > s always
      if(d.y > s.y + s.h/2)
        return +1;

      // Case 2: d is above s => d < s always
      if(s.y > d.y + d.h/2)
        return -1;

      // Case 3: d is in the same row as s:
      else {
        // Case 3.1: d is at the left of s => d > s
        if(d.x > s.x + s.w/2)
          return +1;
        // Case 3.2: d is at the right of s => d < s
        if(s.x > d.x + d.w/2)
          return -1;
        // Case 3.3: d is over s => d = s
        else
          return 0;
      }
    };

from jquery-gridly.

ksylvest avatar ksylvest commented on June 12, 2024

@tafuentesc Interesting. I'm not sure if I understand exactly how your code differs. It appears the second else clause isn't really required and therefore it could be written as:

Gridly.prototype.compare = function(d, s) {
  if (d.y > (s.y + (s.h / 2))) {
    return +1;
  }
  if (s.y > (d.y + (d.h / 2))) {
    return -1;
  }
  if (d.x > (s.x + (s.w / 2))) {
    return +1;
  }
  if (s.x > (d.x + (d.w / 2))) {
    return -1;
  }
  return 0;
};

Was the only problem with the original that the offsets were wrong?

from jquery-gridly.

ksylvest avatar ksylvest commented on June 12, 2024

Closing again due to inactivity. If original askers can explain the last question we can definitely re-open.

from jquery-gridly.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.