Comments (5)
posguy99
commented on August 18, 2024
I'm lost. My 10.15.5 Mac is currently at 588a1ff, and it passes all the regression tests. I backed up the 10.14.6 machine to that same commit, and it fails.
I completely deleted my clone on the 10.14 machine and started over, it still fails.
I honestly can't tell you when the 10.14 machine last passed the tests, if it built on the 10.15 machine and passed, I have been just building it and installing it and not running the regression tests. My bad.
The 10.14 machine is using ksh93u+m as the shell, the 10.15 machine is not, it's using 93u+. But that should not make any difference, right?
Edit: No, reverting to 93u+ as $SHELL on the 10.14 machine didn't change anything.
from ksh.
posguy99
commented on August 18, 2024
Ok, someone smarter than me is going to have to explain this one.
On the 10.15 machine...
[11:58 AM][ttys000][~/src/ksh]
[102] mbp13 $ bin/shtests leaks
#### Regression-testing /Users/mwilson/src/ksh/arch/darwin.i386-64/bin/ksh ####
test leaks begins at 2020-07-10+11:58:44
test leaks passed at 2020-07-10+11:58:45 [ 6 tests 0 errors ]
test leaks(C.UTF-8) begins at 2020-07-10+11:58:45
test leaks(C.UTF-8) passed at 2020-07-10+11:58:45 [ 6 tests 0 errors ]
test leaks(shcomp) begins at 2020-07-10+11:58:45
test leaks(shcomp) passed at 2020-07-10+11:58:45 [ 6 tests 0 errors ]
Total errors: 0
CPU time user: system:
main: 0m00.00s 0m00.01s
tests: 0m00.30s 0m00.68s
ssh'd to the 10.15 machine from the 10.14 machine...
[12:00 PM][ttys002][~]
[12] iMac $ ssh mbp13.local
Last login: Fri Jul 10 11:58:04 2020 from 192.168.0.60
[Jul 10 12:01:01 PM][ttys001][~]
[4] mbp13 $ cd src/ksh
[Jul 10 12:01:01 PM][ttys001][~/src/ksh]
[5] mbp13 $ bin/shtests leaks
#### Regression-testing /Users/mwilson/src/ksh/arch/darwin.i386-64/bin/ksh ####
test leaks begins at 2020-07-10+12:01:22
test leaks passed at 2020-07-10+12:01:23 [ 6 tests 0 errors ]
test leaks(C.UTF-8) begins at 2020-07-10+12:01:23
test leaks(C.UTF-8) passed at 2020-07-10+12:01:23 [ 6 tests 0 errors ]
test leaks(shcomp) begins at 2020-07-10+12:01:23
shcomp-leaks.ksh[102]: memory leak with read -C when using <<< (leaked 48 bytes)
test leaks(shcomp) failed at 2020-07-10+12:01:23 with exit code 1 [ 6 tests 1 error ]
Total errors: 1
CPU time user: system:
main: 0m00.00s 0m00.01s
tests: 0m00.32s 0m00.72s
Same git repo (physically!), commit 588a1ff.
EDIT: I just tried copying the repository from the 10.15 machine to the 10.14 machine. The same compiled binary fails the test on the 10.14 machine.
from ksh.
posguy99
commented on August 18, 2024
More ridiculousness... I deleted the repo on the 10.14 machine, and re-cloned from HEAD. Built it. Got the memory leak.
Then I ssh'd to the 10.14 machine from the 10.15 machine, ran the test again, and it PASSED.
/me very confused.
from ksh.
McDutchie
commented on August 18, 2024
Hrm. I can't reproduce any failure on my end.
We can be pretty confident it's not a leak in read -C when using <<< though, because that test is repeated 500 times, so if the leak was in there it would leak a lot more than 80 bytes.
I've no idea why these random minor variations occur, but all the leak tests are repeated in loops to make the leak significantly large if there is one, so I'll just have to program in some tolerance, I guess – maybe 128 bytes?
Thanks for the report in any case.
from ksh.
posguy99
commented on August 18, 2024
The problem is back, built from HEAD on 10.15.6.
[ 9:03 AM][ttys000][~/src/ksh][master]
[359] mbp13 $ bin/shtests leaks
#### Regression-testing /Users/mwilson/src/ksh/arch/darwin.i386-64/bin/ksh ####
test leaks begins at 2020-07-29+09:04:11
test leaks passed at 2020-07-29+09:04:11 [ 6 tests 0 errors ]
test leaks(C.UTF-8) begins at 2020-07-29+09:04:11
leaks.sh[72]: variable value reset memory leak -- 48 bytes after 1000 iterations
test leaks(C.UTF-8) failed at 2020-07-29+09:04:11 with exit code 1 [ 6 tests 1 error ]
test leaks(shcomp) begins at 2020-07-29+09:04:11
test leaks(shcomp) passed at 2020-07-29+09:04:11 [ 6 tests 0 errors ]
Total errors: 1
CPU time user: system:
main: 0m00.007s 0m00.014s
tests: 0m00.153s 0m00.220s
[ 9:04 AM][ttys000][~/src/ksh][master]
[360] mbp13 $ git log | tee
commit 05081dfc1c6ef18eee06d2a31c3f1cb4bb68d9d7
Author: Johnothan King <[email protected]>
Date: Mon Jul 27 05:27:20 2020 -0700
from ksh.
Related Issues (20)
- Parsing bug in definition of custom arithmetic functions HOT 2
- Declaration utilities perform assignments immediately before expanding remaining command arguments HOT 13
- FreeBSD: termcap detection fails, causing multiline errors HOT 3
- globstar fails to resolve symlink HOT 1
- [Heads up] Build broken this morning HOT 12
- When multiline is off, the first line entered after shell start or window resize starts scrolling too late HOT 1
- FreeBSD arm64: Various pty.sh test failures HOT 17
- macOS Ventura detects termcap support, not terminfo support HOT 3
- ${var+set} still does not work correctly within loops HOT 4
- `typeset -p` output for `[type]` syntax needs quoting HOT 1
- Upon new shell or TERM change, command completion fails outside of the default path HOT 6
- `unset -f whence` removes `whence` builtin in comsub? HOT 9
- `(unset -f fun)` fails within namespace HOT 1
- Spurious syntax error in `case` with extended expression HOT 6
- Tab completion fails on functions and shell builtins when an autoloaded function is "undefined" HOT 7
- pty test random failure HOT 18
- Race condition in job notification HOT 1
- regression - glob expansion with brace expansion and parameter exapansion HOT 11
- Intermittent types test failure on Debian 11 aarch64 box HOT 5
- Intermittent pty test failure on Kali Linux ARM64 HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from ksh.