Code Monkey home page Code Monkey logo

Comments (7)

sivanantha321 avatar sivanantha321 commented on September 23, 2024 2

@scottclusk The port is exposed with name aggr-metric on pod. https://github.com/kserve/kserve/pull/3291/files

from kserve.

sivanantha321 avatar sivanantha321 commented on September 23, 2024

You can use PodMonitor instead of using ServiceMonitor. prometheus-operator/prometheus-operator#3119

from kserve.

robertgshaw2-neuralmagic avatar robertgshaw2-neuralmagic commented on September 23, 2024

@sivanantha321 thanks. This is the approach i needed up taking and it worked well

from kserve.

scottclusk avatar scottclusk commented on September 23, 2024

Hello @robertgshaw2-neuralmagic any chance you elaborate on the fix please? I'm having the same issue, and it seems to me that the podMonitor also requires a named port. targetport is deprecated and port requires a number no? thanks :)

from kserve.

robertgshaw2-neuralmagic avatar robertgshaw2-neuralmagic commented on September 23, 2024

Hello @robertgshaw2-neuralmagic any chance you elaborate on the fix please? I'm having the same issue, and it seems to me that the podMonitor also requires a named port. targetport is deprecated and port requires a number no? thanks :)

WIP example -> https://github.com/robertgshaw2-neuralmagic/vllm-k8s/tree/main/vllm-kserve

I ended up using the following:

apiVersion: monitoring.coreos.com/v1
kind: PodMonitor
metadata:
  name: llama-3-monitor
spec:
  namespaceSelector:
    any: true
  selector:
    matchLabels:
      serving.kserve.io/inferenceservice: llama-3
  podMetricsEndpoints:
  - port: user-port
    interval: 5s

The user-port is 8000 ... the InferenceService seems to expose this

from kserve.

scottclusk avatar scottclusk commented on September 23, 2024

Hello @robertgshaw2-neuralmagic any chance you elaborate on the fix please? I'm having the same issue, and it seems to me that the podMonitor also requires a named port. targetport is deprecated and port requires a number no? thanks :)

WIP example -> https://github.com/robertgshaw2-neuralmagic/vllm-k8s/tree/main/vllm-kserve

I ended up using the following:

apiVersion: monitoring.coreos.com/v1
kind: PodMonitor
metadata:
  name: llama-3-monitor
spec:
  namespaceSelector:
    any: true
  selector:
    matchLabels:
      serving.kserve.io/inferenceservice: llama-3
  podMetricsEndpoints:
  - port: user-port
    interval: 5s

The user-port is 8000 ... the InferenceService seems to expose this

How does it find your aggregate metrics though, aren't those being exposed on 9088?

from kserve.

robertgshaw2-neuralmagic avatar robertgshaw2-neuralmagic commented on September 23, 2024

It doesn't aggregate.

But you could then open up a Servicemonitor that hits the 9091 if you want to get the queue_proxy metrics

from kserve.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.