Comments (11)
I've seen some issues with S3 and pluses, and also found recently that apt-transport-https has a bug with handling pluses. I'll take another review to double check.
Which version of deb-s3 are you running?
from deb-s3.
deb-s3 (0.6.1)
from deb-s3.
I believe the issue is that the filenames in the Packages file are URL-escaped and they shouldn't be as per this Debian wiki page. I have a patch for this that I can PR tomorrow, it seems to have fixed similar issues for us that we've been having with colons in the filename.
from deb-s3.
Although the filenames are fixed in the Packages manifest now (at least here in master, but not in rubygems), the uploaded filenames are now URL escaped so the manifest points to the wrong file.
So a file called "asdf+wheezy.deb" gets uploaded as "asdf%2Bwheezy.deb"
from deb-s3.
I take that back. Here's the filename I'm dealing with:
"pool/f/fr/freeswitch-lang-pt_1.4.14+git20141209T231522Z1055ac8cf9-1~wheezy+1_all.deb"
So in the Packages manifest the filename contains +s, and the filename on S3 also contains +s, but the link created by S3 for the file contains %2Bs.
from deb-s3.
I just tried with 7.1 and I am still seeing the the Filename in the actual repo files being URL encoded which it should not be.
From: http://deb-repo.rov.com/dists/pre-release/debian/binary-armhf/Packages
...
Package: rov-avrdude
Version: 1:5.11.1-1~24.ad04c42
License: unknown
Vendor: @04d7752423d9
Architecture: armhf
Maintainer: [email protected]
Installed-Size: 1478
Section: default
Priority: extra
Homepage: http://example.com/no-uri-given
Filename: pool/o/op/rov-avrdude_1%3A5.11.1-1~24.ad04c42_armhf.deb
Size: 482248
SHA1: d9a8834add57756de41eb68092471d6b3b3bfcff
SHA256: 542ae3f40f78ed722401891302867c10e258c45b67fe046e425e422ca3ec7a16
MD5sum: c023e18f2fea9b6d2620169948d09db0
Description: ROV avrdude package
Note the Filename: pool/o/op/rov-avrdude_1**%3A**5.11.1-1~24.ad04c42_armhf.deb above
I did confirm that #45 looks to be merged in master. Any ideas?
from deb-s3.
I fixed the last issue I had in PR #77
from deb-s3.
still an issue with ~
, e.g. 3.4.1-2~bpo80+1
Used 0.7.1 to upload to s3. It worked when url gets escaped, which seems not to be done by apt-get. If it's not "allowed" to put escaped URLs into the Release file, then this will not be able to get fixed, unless Amazon decides to auto-escape such requests.
from deb-s3.
This issue has pingponged. I've had bugs filed with it both ways. I'm planning on just changing it to strip the problem characters from the filename.
from deb-s3.
The root issue is S3 mangling + -> " ". https://github.com/sigil66/apt-transport-s3/blob/master/src/s3%2Bhttp.cc#L686
I hate this issue so very much.
from deb-s3.
Is this fixed now?
from deb-s3.
Related Issues (20)
- 0.9.1 removed the --use-ssl flag
- does not match the server certificate
- How to use gpg2? HOT 1
- gpg: cannot open tty `/dev/tty' HOT 1
- Signing package HOT 1
- weak digest algorithm HOT 1
- --fail-if-exists has no effect HOT 5
- InRelease should be generated by default HOT 4
- Prune orphaned packages from s3
- Method missing `public_url` in #<Seahorse::Client::Response> with --fail-if-exists HOT 1
- error in deb-s3 show: wrong number of arguments
- error in deb-s3 verify HOT 2
- S3-backed configuration configuration file?
- Re-genning `deb-s3` binary
- The authorization header is malformed; the Credential is mal-formed; expecting "<YOUR-AKID>/YYYYMMDD/REGION/SERVICE/aws4_request". HOT 2
- Can't upload packages built with Ubuntu Bionic HOT 3
- create signed repo
- Security: deb-s3 incorporates existing release/manifests without verifying signatures HOT 2
- Maintainers: This is not the repo you're looking for! HOT 3
- Add link to the active fork & transfer gem ownership? HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from deb-s3.