Code Monkey home page Code Monkey logo

Comments (9)

rudiedirkx avatar rudiedirkx commented on June 16, 2024

Sounds good. Sounds like a PR!

from laravel-form-builder.

ukeloop avatar ukeloop commented on June 16, 2024

Do you think we should always not include template_prefix in Templates? If Templates has template_prefix, it's duplicated.

from laravel-form-builder.

rudiedirkx avatar rudiedirkx commented on June 16, 2024

Eh? Do you mean template_prefix in the config file? I don't use it, but it works, right?

from laravel-form-builder.

ukeloop avatar ukeloop commented on June 16, 2024

I would like to change the view file as well for each Theme.

return [
    'themes' => [
        'default' => [
            // ...

            'template_prefix' => 'laravel-form-builder::',
        ],
        'foo' => [
            // ...

            'template_prefix' => 'forms.foo.',
        ],
    ],

    // ...
];

Templates doesn't need have template prefix.

from laravel-form-builder.

rudiedirkx avatar rudiedirkx commented on June 16, 2024

I don't get it. What is Templates?

It's dangerous to change the entire config structure. That would probably break bc.

from laravel-form-builder.

ukeloop avatar ukeloop commented on June 16, 2024

So it is not PR, it's issue.

If it is difficult to change only class, as in the case of Horizontal form, it is necessary to change view files.

I currently use form_label and form_widget instead of form_row when I need a form with a special layout.

from laravel-form-builder.

rudiedirkx avatar rudiedirkx commented on June 16, 2024

I use form and row classes and custom CSS to do different layouts. There's many ways to do this. And every dev can do them. How much effort do you want to put into themes that won't work for everyone, but have to work for more than just yourself?

from laravel-form-builder.

ukeloop avatar ukeloop commented on June 16, 2024

But Symfony form can change view files by theme.

from laravel-form-builder.

rudiedirkx avatar rudiedirkx commented on June 16, 2024

This form builder isn't much like Symfony anymore. But you can PR anything you like, and if it's backward compatible, we might add it. That's the most important IMO: backward compatible.

from laravel-form-builder.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.