Code Monkey home page Code Monkey logo

Comments (5)

frenzzy avatar frenzzy commented on June 9, 2024 1

Have you tried to add a universal-router.d.ts in your project source root with the following content?

declare module 'universal-router' {
  export interface Route {
    customProperty: any;
  }
}

Just found an article: TypeScript: Adding Custom Type Definitions for Existing Libraries

Also I will try to find time next week to update PR #183 and release v9, but it is not guaranteed 🤷‍♂️

from universal-router.

frenzzy avatar frenzzy commented on June 9, 2024

@jazblueful, hi!
Currently the router does not accept a route type. The second type variable is route result but not route.

- new UniversalRouter<Context, Route>(routes, options)
+ new UniversalRouter<Context, Result>(routes, options)

so, the only way to extend Route type is to add an extended interface in your code and typescript will merge them.

import { Route } from 'universal-router'

interface Route {
  customProperty: any;
}

// ...

I want to allow to redefine Route type in the next router version, see todo in #183

from universal-router.

webican avatar webican commented on June 9, 2024

hi @frenzzy,
Thanks for a quick reply and clarification. It makes sense regarding the Result type.

However when I try to extend Route type this way I get: "TS2440: Import declaration conflicts with local declaration of 'Route'."

from universal-router.

webican avatar webican commented on June 9, 2024

It looks like merging imported and local interfaces was removed in TS 3.7 https://devblogs.microsoft.com/typescript/announcing-typescript-3-7-rc/#local-and-imported-type-declarations-now-conflict and only option for me is to wait for the next router version.

from universal-router.

webican avatar webican commented on June 9, 2024

Awesome! thank you @frenzzy :)

from universal-router.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.