Code Monkey home page Code Monkey logo

Comments (8)

bradparks avatar bradparks commented on May 21, 2024 2

cool.... i'll give that a shot... and if possible, I'd think it'd be a good idea to have your it check the node version and fail with a nice message there if the node version was too old.... thanks!

from react-app.

bradparks avatar bradparks commented on May 21, 2024 1

hey... tried it and it worked.... thanks a bunch !

from react-app.

bradparks avatar bradparks commented on May 21, 2024 1

Ultimately if you have it as a feature, or as a doc it implies it needs to be supported in some way.

To me, a doc seems simpler, but the code does something and it's easier to verify that it works, and of course would help people do an important thing - get their site published somewhere.

So I'd say a publish option is better than a doc....

from react-app.

koistya avatar koistya commented on May 21, 2024 1

Now it should print the following message to the console, if you attempt to use this tool with Node < 6:

ERROR: This tool requires Node.js v6 or higher.

react-app v1.1.2
react-app-tools v1.1.2

from react-app.

koistya avatar koistya commented on May 21, 2024

@bradparks it requires Node.js >= 6. Is this OK for you? Pro tip: You can have multiple versions of Node installed on your machine via nvm.

from react-app.

koistya avatar koistya commented on May 21, 2024

@bradparks always welcome! BTW, what do you think about this config.js file which I'm planning to add into the default project template: #19

The goal of it is to provide some info, where the application should be deployed to etc. as well as to allow tweaking Webpack config in case the defaults are not good enough :)

Having this config file you will be able to publish your site by running react-app publish

from react-app.

bradparks avatar bradparks commented on May 21, 2024

I think the basic idea looks good... I think it does assume/suggest that people are using this to build a website, when I think just as many people would be using it to build an offline app. But having the option to both publish and 'build-for-manual-deploy` would be great of course.

from react-app.

koistya avatar koistya commented on May 21, 2024

@bradparks or is it better to have this in docs instead? For example:

How to Deploy

In order to deploy your web app to GitHub Pages:

  1. Create config.js file in the root of your project
  2. Export an object containing deployment: { repository: '...', branch: '...' } field

from react-app.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.