jquery-complexify is currently behaving differently from the documentation in respect

Same problem (but easy fix possible) Change: <div class="highlight highlight-s

Requesting feedback on correct interpretation of docs on banlist about angular-complexify HOT 4 OPEN

Download commented on June 27, 2024

Requesting feedback on correct interpretation of docs on banlist

from angular-complexify.

Comments (4)

chickahoona commented on June 27, 2024

Same problem (but easy fix possible)
Change:

            self.inBanlist = function(str) {
                for (var i = 0, c = options.bannedPasswords.length; i < c; i++) {
                    //line with problems incoming:
                    if (options.bannedPasswords[i].indexOf(str) !== -1) {
                        return true;
                    }
                }
                return false;
            };

            self.inBanlist = function(str) {
                for (var i = 0, c = options.bannedPasswords.length; i < c; i++) {
                    //fixed line incoming:
                    if (str.indexOf(options.bannedPasswords[i]) !== -1) {
                        return true;
                    }
                }
                return false;
            };

In addition you should update your blacklist, otherwise every password with a '0' drops to 0%, as 0 is on the blacklist ... (someone really hated 0 here :D )

from angular-complexify.

Download commented on June 27, 2024

I've come to the conclusion that strict mode is unusable for me due to the current behavior.

from angular-complexify.

Kraku commented on June 27, 2024

Repo is updated to the latest jQuery version. Strict mode is not perfect, I'll try to improve it soon.

from angular-complexify.

Download commented on June 27, 2024

I have no gripes with angular-complexify, it's the implementation in complexify itself. Actually, the docs describe a very sensible solution, but the actual implementation is sort of 'greedy', matching way more than it should.

from angular-complexify.

Recommend Projects