Event listeners on `window` breaks server-side rendering about beaver-logger HOT 6 CLOSED

@mnicpt can you take a look at ^^?

from beaver-logger.

(it would be good to add a jest test with env:node so we can quickly see if any future calls to window cause the same issue in a non-browser env)

from beaver-logger.

@mnicpt I think it is meant for client-side, but with server-side rendering, e.g. with React server-side rendering, the client-side components and code are rendered on the server, i.e. they are rendered to string to be passed down to client as initial HTML markup.

If uses of window or other client-side libraries are contained to lifecycle methods, e.g. on click handlers, React useEffect, etc., then we're okay bc those processes won't execute on the server. But in this specific case, the event listeners are being added to window in the "main thread"/index.js of this package. Thus, when it's being rendered on the server, the code is imported, immediately executes and fails.

from beaver-logger.

@kweiberth This has been merged and will be deployed this week sometime. Thanks.

from beaver-logger.

In the meantime, I was able to lock in at [email protected] and avoid this issue.

from beaver-logger.

@bluepnume I thought Logger was meant for client-side only. Should @kweiberth be creating a custom logger that he can configure with the express endpoint on the server? We reference the window all over the place in logger.js.

from beaver-logger.