homebridge-wink causes homebridge to crash if wink API is unavailable. about homebridge-wink HOT 11 CLOSED

Looking at the stack trace closer this actually seems to be an issue with wink-js. I'm working on a branch to handle the exception out of wink-js

from homebridge-wink.

I've created a PR in winfinit/wink-js#4 for fixing the underlying issue in wink-js. I need to spend more time learning the node.js async error handling to see how to handle this on the homebridge-wink side if the wink-js issue doesn't get fixed.

from homebridge-wink.

Thank you. Looks like wink-js needs a new npm publish as well. The one on the wink-js github fixes the issue of the huge data dump to the console by putting it into a debug output instead of console.

from homebridge-wink.

Yah I asked in the issue we'll see if he gets it out.

from homebridge-wink.

Looks like the npm module has been updated. I think you just need to run "npm update" on homebridge?

from homebridge-wink.

Nope an update doesn't work. the packages.json is defining ^0.0.9. The wink-js update was done as version 0.1.0 and so it doesn't update to it. I've open a PR to fix this we'll need a new release though.

from homebridge-wink.

Well according to https://www.npmjs.com/package/semver the ^0.1.0 will get be 0.1.0 <= ver < 0.2.0 I guess it depends on how @winfinit is planning on versioning wink-js. Based on the semver info ^0.1.0 is correct as 0.1.x should guarantee no breaking api changes where >0.1.0 things could break as a 0.2.0 could have a incompatible API change.

from homebridge-wink.

That makes a lot more sense. Thanks for that explanation.

from homebridge-wink.

Although I am not fully complying to "semver", however I do strongly agree with "semver" summary:

• MAJOR version when you make incompatible API changes
• MINOR version when you add functionality in a backwards-compatible manner
• PATCH version when you make backwards-compatible bug fixes

so you can feel safe to update MINOR version.

from homebridge-wink.

Great thanks @winfinit so I'll update it to be 0.1.0 < ver < 1.0.0 then.

from homebridge-wink.

Released in 1.0.3

from homebridge-wink.