Code Monkey home page Code Monkey logo

Comments (6)

kraaden avatar kraaden commented on May 24, 2024

Just replace

import { autocomplete, AutocompleteSettings, AutocompleteItem, AutocompleteResult } from "autocompleter";

with

import autocomplete, { AutocompleteSettings, AutocompleteItem, AutocompleteResult } from "autocompleter";

and then it should work.

from autocomplete.

tiagomsmagalhaes avatar tiagomsmagalhaes commented on May 24, 2024

Thanks. Why does it have to be outside brackets and the others inside? Tried to look for other examples but couldn't find an explanations

from autocomplete.

kraaden avatar kraaden commented on May 24, 2024

This is because all interfaces are declared as named exports, but autocomplete is default export in the package.

I would acually prefer to add named export for autocomplete too, but if I do this, rollup will modify UMD header and replace global declaration for autocomplete with autocomplete.autocomplete.

Currently UMD header looks like this:

(function (global, factory) {
  typeof exports === 'object' && typeof module !== 'undefined' ? module.exports = factory() :
  typeof define === 'function' && define.amd ? define(factory) :
  (global.autocomplete = factory());
}(this, (function () { 'use strict';
...

and if I change function declaration to export function autocomplete..., then the generated UMD header will look like this:

(function (global, factory) {
  typeof exports === 'object' && typeof module !== 'undefined' ? factory(exports) :
  typeof define === 'function' && define.amd ? define(['exports'], factory) :
  (factory((global.autocomplete = {}))); // must be called as autocomplete.autocomplete(...)
}(this, (function (exports) { 'use strict';

from autocomplete.

planger avatar planger commented on May 24, 2024

When importing autocomplete as below, I still get a TypeError: c.default is not a function.

import autocomplete, { AutocompleteSettings, AutocompleteItem, AutocompleteResult } from "autocompleter";

The only way of importing autocomplete that works for me is:

const configureAutocomplete: (settings: AutocompleteSettings<YourItemType>) => AutocompleteResult = require("autocompleter");

Could this be related to Babel? See also microsoft/TypeScript#5565

Thanks a lot!

from autocomplete.

kraaden avatar kraaden commented on May 24, 2024

@planger This is exactly how it should work. I tried to reproduce this issue, but I can compile it with both babel and typescript without any issues:

https://github.com/kraaden/autocomplete-tst/tree/master/my-app

from autocomplete.

planger avatar planger commented on May 24, 2024

@planger This is exactly how it should work. I tried to reproduce this issue, but I can compile it with both babel and typescript without any issues:

https://github.com/kraaden/autocomplete-tst/tree/master/my-app

Thanks a lot for the fast reply, @kraaden!

Good that it works in the test project. I'm not sure why it doesn't work in our project though. I guess there seems to be a difference in the transpiler config... hm. Thanks anyways!

from autocomplete.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.