Code Monkey home page Code Monkey logo

Comments (3)

kraaden avatar kraaden commented on May 24, 2024 4

added to 2.2.1

from autocomplete.

kraaden avatar kraaden commented on May 24, 2024

Yes, the widget doesn't include throttling/debouncing, because I try to keep it as small as possible.

You can just use autocomplete with an external debounce package from NPM
https://www.npmjs.com/search?q=debounce

import { debounce } from 'some-debounce-package';

autocomplete({
    fetch: debounce(function(...) { ... }, 250),
    ...
});

from autocomplete.

corford avatar corford commented on May 24, 2024

It's true but for situations where you just want to drop in autocomplete via an external link, it's a tiny bit of extra friction for a feature that imho belongs native to the autocomplete plugin.

In terms of keeping code small as possible, I totally agree (and this is one of the main reasons I'm using your autocomplete). However, adding debounce would require about ~5 lines of code (I think?).

This:

if (val.length >= minLen) {
  settings.fetch(val, function(elements: Array<T>): void {
    if (keypressCounter === savedKeypressCounter && elements && !unloaded) {
      items = elements;
      inputValue = val;
      selected = items.length > 0 ? items[0] : undefined;
      update();
    }
  });
} else {
  clear();
}

Would become:

if (val.length >= minLen) {
  window.clearTimeout(debounceTimer);
  debounceTimer = window.setTimeout(function() {
    settings.fetch(val, function(elements: Array<T>): void {
      if (keypressCounter === savedKeypressCounter && elements && !unloaded) {
        items = elements;
        inputValue = val;
        selected = items.length > 0 ? items[0] : undefined;
        update();
      }
    });
  }, debounceWaitMs);
} else {
  clear();
}

Then add debounceTimer and debounceWaitMs vars:

const debounceWaitMs = settings.debounceWaitMs || 25;
let debounceTimer : T | undefined;

from autocomplete.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.