Highlight package when a new version is available about poetry-pycharm-plugin HOT 12 OPEN

@systemallica
Thank you for creating this issue.
I think it's a great idea.
I will try it.

from poetry-pycharm-plugin.

@koxudaxi I think it's a feature of this plugin: https://plugins.jetbrains.com/plugin/10837-requirements

Sorry I forgot go mention it.

from poetry-pycharm-plugin.

@systemallica
OK, I will check it.

from poetry-pycharm-plugin.

I have understood how do I implement it.
I will try it 🚀

from poetry-pycharm-plugin.

Glad to hear that! Keep up the good work 😁

from poetry-pycharm-plugin.

@systemallica
I have implemented the feature.
This plugin run poetry show --outdated to get outdated version.

The feature only shows a warning when there is the latest version.
It doesn't provide QuickFix that is an action to resolve the warning (exp install a new version)
because I don't know what does the plugin should do it.

How did you think about it?

from poetry-pycharm-plugin.

OK, I have pushed the latest version to the JetBrains server via GitHub Action.
It will be approved within two business days.
After, we can download it.

from poetry-pycharm-plugin.

@systemallica

However I noticed that the plugin does not look for new versions until I modify the pyproject.toml file.

I may have to change the way to inspect pyproject.toml 🤔

Imo, it should stop being highlighted after step 1. What do you think?

Now, The plugin calls poetry show --outdated when pycharm detect package updated.
And, outdated versions will be highlighted.
It means the plugin doesn't parse pyproject.toml.

Change the version

If we want to detect the version in the plugin then I have to implement a version parser.
I need the time to do it.

Sorry, I am not a PyCharm master. I must learn PyCharm APIs to develop plugins 🤓

I don't close this issue. I will improve the feature when I get the time.

from poetry-pycharm-plugin.

@systemallica
I can't see the popup in my environment 🤔
How do I reproduce showing the popup?

from poetry-pycharm-plugin.

That looks awesome! Thank you very much.

It's ok if it doesn't offer you a quickfix, knowing that there's a new version is the most important part imo. Then the user can change the version manually and run 'poetry update' ☺️

from poetry-pycharm-plugin.

@koxudaxi I just installed 0.1.2 and it works pretty well, thank you!

However I noticed that the plugin does not look for new versions until I modify the pyproject.toml file. If I'm not mistaken, with a requirements.txt file, the inspection happens automatically without the need of modifying the file. Is this something that could be done withe your plugin?

Another thing I noticed is that, once a package is highlighted, it will remain highlighted until you:

1. Change the version
2. Run poetry update
3. Change something in the file so that the inspection runs again

Imo, it should stop being highlighted after step 1. What do you think?

Anyway thank you for your work :D

from poetry-pycharm-plugin.

I just wanted to add an edge case here to be aware of. poetry show --outdated compares against the installed lock version and whats available. Starting to use the plugin it was highlighting some of my dependencies with versions like ^8.0.0. saying the version is outdated and a newer one is available like 8.1.0.

This technically is correct from the lock standpoint but incorrect from the pyproject.toml standpoint.

As you mentioned you do not parse the version in the plugin so this is hard to avoid, but stating that the lock file is out of date or something there might aid in confusion when the version string would catch the latest version.

from poetry-pycharm-plugin.