Comments (11)
Does the issue reproduce for you with code from the branch #390 ?
from kotlinx-datetime.
I can check tomorrow, though if you're able to get the above test failing that might be faster than me cloning and setting up the kotlinx-datetime library.
Also, I failed to mention this in the original post, but this seems to be a regression in 0.6.0. Prior versions did not exhibit this issue. Perhaps this regression was introduced in #286?
from kotlinx-datetime.
Unfortunately I'm unable to easily check which commit introduced this regression, and whether #390 resolves it. In my library I only noticed this issue because it's a multiplatform projects that offers a Windows binary, and CI started failing when the PR to upgrade this library to 0.6.0 was made. I do not have a personal Windows machine to debug on, and this repository doesn't use something like Github Actions which would allow me to easily test hypotheses in my own fork.
If anyone with a Windows machine wants to pull this repository and copy/paste the above test to see which commit introduced the regression, that would be helpful.
from kotlinx-datetime.
I can now confirm in my own fork that even #390 fails here. https://github.com/kevincianfarini/kotlinx-datetime/actions/runs/9292913736/job/25574876223?pr=2#step:4:182
from kotlinx-datetime.
Oh, this is actually a known bug, I just forgot to file it; filed it now: #403. Thanks for raising the problem!
from kotlinx-datetime.
Is this issue new as of #286, or has this existed elsewhere prior? I haven't upgraded to 0.6.0 yet because it's failing a CI check for me.
from kotlinx-datetime.
I can't say this conclusively without looking deeply into it, but IIRC, it didn't exist on Windows but has always existed on the JVM and JS, and then got ported to Native as well (including Linux). The exact datetimes where the issue is observed are just different across platforms. So, this isn't really a regression but an evolution of a bug.
from kotlinx-datetime.
I see. Is this something that will perhaps be resolved in 0.6.1
? Or would this require a more disruptive change?
from kotlinx-datetime.
I used to think that this issue required some design discussions, but now that I'm looking at it again, it seems fairly straightforward. I'll try to fix it for 0.6.1.
from kotlinx-datetime.
Amazing, thank you so much.
from kotlinx-datetime.
Looks like I was mistaken and this is a regression, plain and simple. I couldn't reproduce this class of issues on the JVM and JS, so the fix only touches Native and was very straightforward to make: #404
from kotlinx-datetime.
Related Issues (20)
- Consider moving `Instant` and `Clock` to the standard library
- Not supported on Android 7.0? What are the minimum supported Android and IOS versions? HOT 2
- Missing methods we had before in Java HOT 3
- Unable to execute kotlin native packaging HOT 5
- Localization format HOT 1
- Add a top-level description to the API reference
- Issue with R8 minification HOT 3
- Inconsistent behavior for dates on the edges of time overlaps
- The parsing API accepts non-ASCII digits
- Support WasmWasi HOT 1
- Is KMM still possible for apps that supports SDK 21? HOT 3
- Inherit the specified TimeZone when converting between Instant and LocalDateTime using toInstant and toLocalDateTime?
- How to get epoch milliseconds of start of the day in UTC? HOT 2
- What is the purpose of specifying TimeZone? HOT 2
- Add a dayOfYear option HOT 3
- The same serial descriptor name is used for several serializers
- Crash - Fatal Exception: java.lang.NoClassDefFoundError HOT 1
- Decide what to do with deprecated time zones
- Precision loss for NSDate HOT 5
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from kotlinx-datetime.