HebrewDateFormatter for JewishCalendar via ikvm, what needs to be set? about zmanim HOT 4 CLOSED

@chacham2 ,
Please see the documentation for getParsha(). When it is not Shabbos, Parsha.NONE is returned, and the formatter formats this as an empty string. The same for formatRoshChodesh() that returns an empty string when it is not Rosh Chodesh. I know that some in the past have expected the parsha returned in middle of the week, but that is not how this API was designed. What output did you expect for formatting a Rosh Chodesh when it is in middle of the month? For additional info, please see documentation in the the source code.

Have a good Shabbos.

from zmanim.

And here i thought i looks at the documentation. Maybe i looked in the wrong area?

What output did you expect for formatting a Rosh Chodesh when it is in middle of the month?

The real answer is that i was just trying a couple to see what worked and what did not. So, i just tried a couple calls and saw they did not work. But from the name of the call, i would have expected the month's rosh chodesh, whenever it was.

I know that some in the past have expected the parsha returned in middle of the week, but that is not how this API was designed.

That is indeed what i would have expected. The names of the calls don't make it so clear what is being returned. I guess i can test what day of the week it is and add the days until Shabbos.

In any case i don't mean to complain, this is a wonderful library. Have a good Shabbos!

from zmanim.

And here i thought i looks at the documentation. Maybe i looked in the wrong area?

What output did you expect for formatting a Rosh Chodesh when it is in middle of the month?

The real answer is that i was just trying a couple to see what worked and what did not. So, i just tried a couple calls and saw they did not work. But from the name of the call, i would have expected the month's rosh chodesh, whenever it was.

I know that some in the past have expected the parsha returned in middle of the week, but that is not how this API was designed.

That is indeed what i would have expected. The names of the calls don't make it so clear what is being returned. I guess i can test what day of the week it is and add the days until Shabbos.

In any case i don't mean to complain, this is a wonderful library. Have a good Shabbos!

from zmanim.

No worries.

from zmanim.