Test Log File Max Total Size failure: corner case for log size about kopia HOT 7 CLOSED

Hi @julio-lopez,

i found another failed test (https://github.com/kopia/kopia/actions/runs/5471439825/jobs/9962578801)
I manually calculated the sizes from the test and found the edge case for this specific case.

Under rare circumstances, the returned log files have the exact same size as provided by the function call.
fail.txt

from kopia.

Hi @julio-lopez,

can you share your system and go-version? We had a failed test in the past and it was not reproduceable on an older go-version / other system. I am on windows 11, go-version 1.20.4. Here is my result:

Running tool: C:\Program Files\Go\bin\go.exe test -timeout 30s -run ^TestLogFileMaxTotalSize$ github.com/kopia/kopia/internal/logfile

=== RUN   TestLogFileMaxTotalSize
=== PAUSE TestLogFileMaxTotalSize
=== CONT  TestLogFileMaxTotalSize
=== RUN   TestLogFileMaxTotalSize/cli-logs
**[...]**
--- PASS: TestLogFileMaxTotalSize/cli-logs (0.45s)
=== RUN   TestLogFileMaxTotalSize/content-logs
**[...]**
--- PASS: TestLogFileMaxTotalSize/content-logs (0.45s)
--- PASS: TestLogFileMaxTotalSize (2.63s)
PASS
ok      github.com/kopia/kopia/internal/logfile 2.805s

from kopia.

@lupusA This has failed a few times in the kopia workflows. The issue was filed for tracking and triaging. The fix should be simple if you want to take a crack at it.

from kopia.

@lupusA The setup is whatever is currently configured in the kopia GH workflows
IIRC, this is not specific to Windows. I recall seeing the failure on other platforms as well. This should be testing bug, not an implementation bug.

from kopia.

Hi @julio-lopez,

i've looked at the test and do not see any issues with it. From what i've seen, the test creates a directory structure and the fires two commands. After each command, the directory size is compared with the one before the command.

The test also do not fail every time. In my github workflow runs it was running fine.

I will try to debug it further.

Cheers,

from kopia.

There is a errornous run attached:
run.txt

from kopia.

@lupusA Thanks for finding a failed run https://github.com/kopia/kopia/actions/runs/5470716647/jobs/9961110427

from kopia.