Embedding Konnectd as dependency? about konnect HOT 4 CLOSED

Sounds like a good idea - i would not oppose a PR which would create like a bootstrap sub modules which holds the logic currently found in the cmd itself (minus the commandline parsing and environment variable logic).

Since lot of things need to happen to startup the services provided by konnectd it is not particularly trivial to collect it all and it seems bad if embedding could would need to replicate it all.

from konnect.

As #19 is nearing completion we would like to propose some follow up changes to further improve embedding.

Configuration files/keys

Instead of storing the path to the file the bootstrap should contain the unmarshaled config struct. With this change the consumer can decide how the load/un-marshall the config during the boot-process (etcd, hard-coded, different format). This would also decouple the business-logic from any io which should also improve test-ability.

This will require some concept on how to add extension-points to the bootstrap. (Extend interface introduced in #19 ?)

Assets (index.html)

Similar as above but here the path to index.html would be replaced by an io.reader of to allow loading assets from an vfs or do some other processing. Identifier-webapp should be optional as it might be hosted on another server.

from konnect.

As #19 is nearing completion we would like to propose some follow up changes to further improve embedding.

Would you please make a ticket for this - so it can be properly discussed there instead of here. Thanks!

from konnect.

This was implemented, since #19 was merged.

from konnect.