Critical dependency due to parse5 dependency about delivery-sdk-js HOT 4 CLOSED

The solution seems to be to use following webpack plugin:

new webpack.ContextReplacementPlugin(
/(.+)?parse5(\\|\/)lib(\\|\/)(.+)?/,
path.join(__dirname, 'src'), 
{} 
)

So, we need to switch to webpack for builds.

from delivery-sdk-js.

This does not completely solve the problem beacuse it many cases we leave compilation up to the client, so they would need to use this webpack plugin (if they were using webpack in the first place).

We have a bundle which solves this.

Ideally though, we might want to consider using our own parser see https://medium.com/@gajus/parsing-absolutely-anything-in-javascript-using-earley-algorithm-886edcc31e5e and https://nearley.js.org/

from delivery-sdk-js.

This is implemented in v4 where we use parse5 (v3 so that dynamic import is not used) for working with HTML under node.js and standard DOM when in browser. So far it seems to be working. More testing is required though.

from delivery-sdk-js.

Closing as fixed

from delivery-sdk-js.