Possibility to set base url for api calls about delivery-sdk-js HOT 8 CLOSED

The urls for delivery and preview API are set in the QueryService class as private readonly attributs.

What about exposing them in the DeliveryClientConfig class? QueryService is already instantiated with the config object.

from delivery-sdk-js.

Sounds Good for me. Looking forward to an implementation and documentation ;).

from delivery-sdk-js.

See how it's implemented in the .net sdk for reference.

from delivery-sdk-js.

alright, so what do you mean by that? Do you ask me to contribute ? Or will you do/delegate it?

I'm open minded in this case :).

from delivery-sdk-js.

@Journerist sorry for confusion, it was rather a generic remark, not addressed to anyone in particular :)

It would be great if you could take care of it.

So what we did in the .NET SDK is that we introduced a DeliveryOptions object, adjusted DeliveryClient's constructors. And here's an example of how it can be used: https://github.com/Kentico/delivery-sdk-net/wiki/Using-the-ASP.NET-Core-Configuration-API-and-DI-to-Instantiate-the-DeliveryClient.

I'm not saying we should do it the exactly same thing but the general look&feel should be somewhat similar :)

Please let us know if you're willing to contribute so that we can assign the issue to you.

from delivery-sdk-js.

Hey guys,

This is a good idea. I implemented it so that you can specify base urls when instantiating DeliveryClientConfig. I published it in 2.1.2 release:

new DeliveryClientConfig('projectId', [], {
      baseUrl: 'http://customurl.com',
      basePreviewUrl: 'http://custompreview.com'
    });

Let me know how that works and if you have any further suggestions.

from delivery-sdk-js.

@Enngage thank you, this is awesome. I'll try it this evening and give you feedback if this works for me.

from delivery-sdk-js.

I already love it, works amazingly. Finally I can get rid of my ugly hack :P. Thanks a lot ! <3

from delivery-sdk-js.