Pagination for Taxonomies about delivery-sdk-js HOT 6 CLOSED

Hey, I would like to help on this issue. Can you explain it a bit?

from delivery-sdk-js.

There are three main endpoints the SDK talks to:

• content items
• content types
• taxonomy groups

By pagination I mean the following part of the response (see above):

 "pagination": {
    "skip": 0,
    "limit": 3,
    "count": 3,
    "next_page": ""
  }

The first two endpoints (content items and content types) already have support in the SDK. E.g.: https://github.com/Enngage/KenticoCloudDeliveryTypeScriptSDK/blob/5c07316d22df39e8c8b95d39cd2b14691f1e312c/lib/models/type/responses.ts

We need to replicate the functionality for the taxonomy groups endpoint. It'll by mostly copying&pasting the code and making sure the data is deserialized correctly. You should verify that by a unit test.

I'd start by searching for "pagination" in the repository to see the existing code.

@Enngage do you have any remarks to add?

from delivery-sdk-js.

@ASP1234 thank you for your interest!
@Enngage can you add Nimish as a collaborator to the project? you'll be able to assign the item to him then.

from delivery-sdk-js.

Hey,

@petrsvihlik Explained things very well, so you can try working on it, just let me know in this thread if you do. Make your fork and submit PR please.

from delivery-sdk-js.

@petrsvihlik Thanks for the explanation. Will send you a PR by tomorrow.

from delivery-sdk-js.

fixed

from delivery-sdk-js.