Code Monkey home page Code Monkey logo

Comments (5)

petrsvihlik avatar petrsvihlik commented on June 24, 2024

Wouldn't this better be solved by using multiple per-env configs?

https://docs.microsoft.com/en-us/aspnet/core/fundamentals/environments?view=aspnetcore-3.1

image

from aspnetcore-extensions.

xantari avatar xantari commented on June 24, 2024

Yeah, that is the other way of doing it. It's just that we would have a lot of extra configurations and each load balanced node would need their own configuration. This would also mean a configuration for each developer for their own local webhook...

from aspnetcore-extensions.

xantari avatar xantari commented on June 24, 2024

Currently this is the only setting that would necessitate all these extra environment configurations in our current project,.. I'd be more inclined to keep the signature handler we have instead of using the new one to avoid all these extra environment configs.

from aspnetcore-extensions.

petrsvihlik avatar petrsvihlik commented on June 24, 2024

Thanks for the explanation!

I understand your arguments but it is the best practice to do it that way. That's exactly what the env-configs are meant for. If it's easier for you to do it differently then go ahead but I don't think it's a good idea to include the aforementioned functionality in this package. Therefore, I'd close the issue now.

If you disagree, feel free to reopen this issue and add more comments.

from aspnetcore-extensions.

xantari avatar xantari commented on June 24, 2024

Sounds good, thanks for taking a look.

from aspnetcore-extensions.

Related Issues (5)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.