[Bug report] Item_Features.js auto generation needs review. about yuan-shen-map HOT 4 CLOSED

I have roughly understood the purpose of this part of the source code.

Why not store the file directly in a JSON file?

from yuan-shen-map.

I have roughly understood the purpose of this part of the source code.

Why not store the file directly in a JSON file?

This generated Item_Features.js is originally the trailing part of Item_Json.js. We just simply split the file into two files Item_Json.js and Item_Features.js, and load in <script> tags in sequence.

Former:

<script src="Item_Json.js"></script>

Now:

<script src="Item_Json.js"></script>
<script src="Item_Features.js"></script>

Since it is too hard to make modifications in this project, we did not do anything more.

If we made it to a JSON file, we have to load it by AJAX in the web pages. However, we are not sure about the side effects of doing this.

from yuan-shen-map.

I have roughly understood the purpose of this part of the source code.
Why not store the file directly in a JSON file?

This generated Item_Features.js is originally the trailing part of Item_Json.js. We just simply split the file into two files Item_Json.js and Item_Features.js, and load in <script> tags in sequence.

Former:

<script src="Item_Json.js"></script>

Now:

<script src="Item_Json.js"></script>
<script src="Item_Features.js"></script>

Since it is too hard to make modifications in this project, we did not do anything more.

If we made it to a JSON file, we have to load it by AJAX in the web pages. However, we are not sure about the side effects of doing this.

I have no idea for it...

However, we can use Webpack's own packer to split all of these data into some source code files automatically, what can communicate with each other by the global scope's variants.

Maybe we should use the other's library instead of our works about it.

from yuan-shen-map.

@langyo

Webpack is hard for this v1 map. The v1 map is totally written in raw html, js and css. Webpack stuff will be a totally refactor.

from yuan-shen-map.