Simplify Module Loading about kong-js-pdk HOT 7 OPEN

And if mtime isn't something used by the kong server for something specific, that could probably just be Date.now()

from kong-js-pdk.

Hi @esatterwhite , thanks for your interest and taking a deep dive into the project! I agree that the logic of loading
a module from file can be simplified, it mostly come from I can't make the require magic just work. That being said,
PRs are welcomed if you can find a simper and cleaner way to do it.
On the other hand, with complicated module layout, the ideal way to do it by having them running in embedded server mode. Normally, you don't want to run multiple different js projects in a same process and expect they don't fight
with each other.

Plugin loading is very disk intensive

I assume the disk consuming conclusion comes from the fact that starting js-pluginserver take several seconds, and
that isn't because those stat or require calls, but comes from loading ts-node. Node does tons lots of other fs operation
when you load from node_modules and those calls doens't really add to noticable overhead.

from kong-js-pdk.

@fffonion

On the other hand, with complicated module layout, the ideal way to do it by having them running in embedded server mode. Normally, you don't want to run multiple different js projects in a same process and expect they don't fight
with each other.

The modules aren't / don't need to be separate plugin servers. There is still a single plugin server in this case. The plugins are just independant modules. Nothing has changed in this setup aside from the fact that they can be a directory which require can still load.

This still works:

pluginserver_names = js
pluginserver_js_one_socket = /usr/local/kong/js_pluginserver.sock
pluginserver_js_one_start_cmd = /usr/local/bin/kong-js-pluginserver --plugin-dir /my/plugins
pluginserver_js_one_query_cmd = /usr/local/bin/kong-js-pluginserver --plugin-dir /my/plugins --dump-all-plugins

from kong-js-pdk.

@fffonion

I agree that the logic of loading a module from file can be simplified, it mostly come from I can't make the require magic just work.

Can you elaborate on this? what did/wouldn't work

from kong-js-pdk.

Normally, you don't want to run multiple different js projects in a same process and expect they don't fight
with each other.

Thats how everything in Node.js works. Every user land npm module is a different project in the same process. This set up isn't particularly any different than that, or referencing globally installed modules. Same thing

from kong-js-pdk.

We don't currently have plans to rework the JS module loading logic. A pull request would be welcome if anyone has interest and time.

from kong-js-pdk.

I think this was done in #101

from kong-js-pdk.