[Improvement] Ability to auto-hide menu bar like on Atom about insomnia HOT 11 CLOSED

Hi @gschier , I am taking up this issue.

from insomnia.

After looking at the Electron documentation, i found that BrowerWindow has a property autoHideMenuBar which enables this behaviour.

autoHideMenuBar Boolean (optional) - Auto hide the menu bar unless the Alt key is pressed. Default is false.

https://electron.atom.io/docs/api/browser-window/#new-browserwindowoptions

Let me know, what you guys think about this option?

from insomnia.

For whoever takes this on, this PR is a good jumping-off point for work atom/atom#4215

from insomnia.

Question:

1. Is this setting going to be found in the preferences section or the view tab?
2. Would you like a keybinding for this improvement as well?

from insomnia.

Nice find @brandonb927! 💯 🥇

from insomnia.

Electron has a setMenu method that looks like it might work to hide the window: https://electron.atom.io/docs/api/browser-window/#winsetmenumenu-linux-windows.

Could add a menu item on Win/Linux to toggle it on the active window. Just have to figure out which hotkey to use.

from insomnia.

Hi everyone! I'm handling issue #195, and its solution will affect this issue. I'll keep you guys posted.

from insomnia.

@PavanKu that looks like exactly what we want. Did you test it out yet?

from insomnia.

@gschier , No. I don't have window or linux machine to test this. 😞

from insomnia.

I took a look at it, I was able to add a checkbox in the settings for toggling auto-hide Menu Bar, but I wasn't sure where to tell Electron to hide/show the bar (looks like there's a BrowserWindow function to set it). I'm on Linux if you have a solution and need me to test it, otherwise I'll keep looking at it tomorrow.

from insomnia.

@Subzidion. Nice!

You can get the current BrowserWindow with electron.remote.BrowserWindow.getFocusedWindow(), then set the option. We'll have to make sure to do this both when the app is first rendered and when the setting changes. It might be a good place to put this in containers/app.js in componentDidMount().

It might also be a good idea to add autoHideMenuBar: true to window-utils.js to prevent the menubar from showing briefly before disappearing.

from insomnia.