Code Monkey home page Code Monkey logo

Comments (3)

obenjiro avatar obenjiro commented on July 30, 2024 9

@kolkov I also want to add:

  1. You actually violating MIT license by removing original author from LICENSE.md and not giving original author any credit.

MIT License have only one important rule "The MIT license requires that "the above copyright notice and this permission notice shall be included in all copies or substantial portions of the Software."

You can write this in LICENSE.md

Copyright (c) 2017 Your Name
Copyright (c) 2015-2016 Previous Developer's Name
Copyright (c) 2014-2016 Other Project Developer's Name

Or you can have your own LICENCE.md with only your name but you should include original MIT license to every file that was forked (put it on top of file)

  1. Attributing previous author is a nice thing to do :) I know that you would also wanted that your work to be credited and mentioned.

PS: thanks a lot for you work on this project 👍

from ngx-gallery.

kolkov avatar kolkov commented on July 30, 2024

Yes, it will be necessary to add this, as long as it is only in the original package in the issues section.

from ngx-gallery.

kolkov avatar kolkov commented on July 30, 2024

@obenjiro thanks for the detailed comment. I will add this info in next update.

from ngx-gallery.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.