Comments (3)
@kolkov I also want to add:
- You actually violating MIT license by removing original author from LICENSE.md and not giving original author any credit.
MIT License have only one important rule "The MIT license requires that "the above copyright notice and this permission notice shall be included in all copies or substantial portions of the Software."
You can write this in LICENSE.md
Copyright (c) 2017 Your Name
Copyright (c) 2015-2016 Previous Developer's Name
Copyright (c) 2014-2016 Other Project Developer's Name
Or you can have your own LICENCE.md with only your name but you should include original MIT license to every file that was forked (put it on top of file)
- Attributing previous author is a nice thing to do :) I know that you would also wanted that your work to be credited and mentioned.
PS: thanks a lot for you work on this project 👍
from ngx-gallery.
Yes, it will be necessary to add this, as long as it is only in the original package in the issues section.
from ngx-gallery.
@obenjiro thanks for the detailed comment. I will add this info in next update.
from ngx-gallery.
Related Issues (20)
- Tif or Tiff image
- fileSource.split is not a function
- Fallback image
- Image Swipe is not working
- Updating to Angular 15 - Peer dependencies cannot resolve HOT 4
- The 'previewForceFullscreen' feature is experiencing issues on Safari.
- only upload small images HOT 1
- Tif Images are not displayed
- imageSwipe/thumbnailsSwipe not working HOT 1
- Angular12: Could not resolve dependency: tslib@"^1.9.3" HOT 1
- Vertical thumbnails on right HOT 3
- Material icons HOT 2
- change icon styles
- On video gallery, can not disable download button
- Angular 13 + V2: No Icons HOT 4
- Using ngx-gallery component in lazy module is not working in Angular 13 HOT 12
- ngx-gallery v2 with Angular13 [Image display problem] HOT 5
- How to use just lightbox feature?
- Image is not visible until mouse over or scroll to the backround area HOT 2
- Updating to Angular 14 - Peer dependencies cannot resolve HOT 5
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from ngx-gallery.