Comments (1)
So I made some changes in a fork and have made a pull request. I checked that all the tests passed and added some new tests for the changes I've made.
Basically this change will let you specify the type of the 'image'. By using the image.type you can specify whether it's an image or a video. The type will be used first if specified, but the function will fall bcak to a slightly altered version of the existing functionality if the type is not specified, where it will attempt to derive the file type from the extension.
Currently the function just splits the filename by . and then pops the last element, assuming that it's a file extension. The change will do the same, except remove anything after a special character, so: mySpecialImage.jpg?alt=media&token=SDFDSFSS will return an image.
I'm new to contributing to projects so happy to make any changes required.
from ngx-gallery.
Related Issues (20)
- Tif or Tiff image
- fileSource.split is not a function
- Fallback image
- Image Swipe is not working
- Updating to Angular 15 - Peer dependencies cannot resolve HOT 4
- The 'previewForceFullscreen' feature is experiencing issues on Safari.
- only upload small images HOT 1
- Tif Images are not displayed
- imageSwipe/thumbnailsSwipe not working HOT 1
- Angular12: Could not resolve dependency: tslib@"^1.9.3" HOT 1
- Vertical thumbnails on right HOT 3
- Material icons HOT 2
- change icon styles
- On video gallery, can not disable download button
- Angular 13 + V2: No Icons HOT 4
- Using ngx-gallery component in lazy module is not working in Angular 13 HOT 12
- ngx-gallery v2 with Angular13 [Image display problem] HOT 5
- How to use just lightbox feature?
- Image is not visible until mouse over or scroll to the backround area HOT 2
- Updating to Angular 14 - Peer dependencies cannot resolve HOT 5
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from ngx-gallery.