Comments (8)
While updating to angular 9, in the official update guide says this:
- Replace /deep/ with ::ng-deep in your styles, read more about angular component styles and ::ng-deep. /deep/ and ::ng-deep both are deprecated but using ::ng-deep is preferred until the shadow-piercing descendant combinator is removed from browsers and tools completely.
In the meantime, I've fixed by adding
ngx-gallery ::ng-deep .ngx-gallery-thumbnails .ngx-gallery-thumbnail {
border: none !important;
}
in the component.scss file.
I think it isn't the best approach because I don't like !important, but I haven't found another solution.
from ngx-gallery.
Yes, at the new version of Angular /deep/
is not working. ( but I tried this at Next versions, may be it working in release, I don't know.
from ngx-gallery.
I can confirm that ::ng-deep
is still working.
from ngx-gallery.
Indeed, ::ng-deep is still working.
Could you maybe update your code? That would fix many webpages' style issues I bet :)
from ngx-gallery.
@PedroJesusRomeroOrtega thanks, are there any other ways in Angular repo issues?
I know only this discussion: angular/angular#25160
from ngx-gallery.
Sorry, I don't know other ways
from ngx-gallery.
Nice catch. Thanks @hijamoya , I was wondering why my styles suddenly broke when updating to this library.
As for the styles, I've been using @PedroJesusRomeroOrtega 's solution. ::ng-deep
works (i haven't find a better solution that doesn't use !important
though). It would be nice to have a better way to control the border style of thumbnails.
from ngx-gallery.
This is still an issue for me, it really messes up the CSS of the rest of the site. Can you not structure your CSS better and not use global declarations?
from ngx-gallery.
Related Issues (20)
- Tif or Tiff image
- fileSource.split is not a function
- Fallback image
- Image Swipe is not working
- Updating to Angular 15 - Peer dependencies cannot resolve HOT 4
- The 'previewForceFullscreen' feature is experiencing issues on Safari.
- only upload small images HOT 1
- Tif Images are not displayed
- imageSwipe/thumbnailsSwipe not working HOT 1
- Angular12: Could not resolve dependency: tslib@"^1.9.3" HOT 1
- Vertical thumbnails on right HOT 3
- Material icons HOT 2
- change icon styles
- On video gallery, can not disable download button
- Angular 13 + V2: No Icons HOT 4
- Using ngx-gallery component in lazy module is not working in Angular 13 HOT 12
- ngx-gallery v2 with Angular13 [Image display problem] HOT 5
- How to use just lightbox feature?
- Image is not visible until mouse over or scroll to the backround area HOT 2
- Updating to Angular 14 - Peer dependencies cannot resolve HOT 5
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from ngx-gallery.