Comments (10)
Hi! It's not a fork, but 100% compatible by API. I will try to implement that PR into this project.
Thanks.
from ngx-gallery.
Hi! Thanks for your request.
Do you want to use video from youtube or from other resources?
from ngx-gallery.
Hi!, thank u for your response, i need to use it with local videos, like .mp4 or .avi.
from ngx-gallery.
+1
from ngx-gallery.
@kolkov wondering if you have a targate date on this enhancement. Thx in advance!
from ngx-gallery.
Thanks for your interesting. I finishing a big project at next week, after that I want to do this enchancement.
If you have a PR, it's speed up my work.
from ngx-gallery.
You forked the project from lukasz-galka's project right?
In which case you saw the pull request that Muhammad Altabba made.
If you could kindly add his code to your repository that would be great.
His code can be found here:
https://github.com/lukasz-galka/ngx-gallery/pull/257/files/b5d80e13a9e376d1065497a464b126f72066e2c1#diff-90871a8f9a0306e34e7bee9f707e475e
In his pull request for lukasz-galka's project.
Please make this work, I can't seem to find any angular gallery package that supports video currently.
EDIT: if it's hard to read the diff changes, what you could do is clone the repository from lukasz-galka and then add the pull request yourself with git, so you can actually look through the code like you would without having to look at the diffs inside the above thread. This might be easier in figuring out where to add this code into your angular 8 version of this project.
If you need help with making the pull request, I might be able to find some time to do this later on. Please let me know if you're having issues with this and I'll help out as much as I can.
from ngx-gallery.
I added video support to my pull request here:
#23
from ngx-gallery.
Pull Request has been merged, I suppose this issue can be set to solved. I don't have the ability to do so though.
from ngx-gallery.
@Simbaclaws thanks for the PR. Try latest version please.
from ngx-gallery.
Related Issues (20)
- Tif or Tiff image
- fileSource.split is not a function
- Fallback image
- Image Swipe is not working
- Updating to Angular 15 - Peer dependencies cannot resolve HOT 4
- The 'previewForceFullscreen' feature is experiencing issues on Safari.
- only upload small images HOT 1
- Tif Images are not displayed
- imageSwipe/thumbnailsSwipe not working HOT 1
- Angular12: Could not resolve dependency: tslib@"^1.9.3" HOT 1
- Vertical thumbnails on right HOT 3
- Material icons HOT 2
- change icon styles
- On video gallery, can not disable download button
- Angular 13 + V2: No Icons HOT 4
- Using ngx-gallery component in lazy module is not working in Angular 13 HOT 12
- ngx-gallery v2 with Angular13 [Image display problem] HOT 5
- How to use just lightbox feature?
- Image is not visible until mouse over or scroll to the backround area HOT 2
- Updating to Angular 14 - Peer dependencies cannot resolve HOT 5
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from ngx-gallery.