Importing kohana-doctrine into the kohana origanisation about core HOT 20 CLOSED

Personally, I would love to see a well maintained Doctrine module around.

But it would mean we are officially endorsing Doctrine. That might be considered opinionated, even if Doctrine is kind of de-facto nowadays. Wouldn't that backfire 🔥 on us?

I looked a bit around the code and it looks good. Congrats 🏆

from core.

@enov I think it's okay to endorse Doctrine but it would not mean we are not open for other ORM's like Propel. If someone would make a module for it I would gladly include it.

But it means we won't be working on our own ORM anymore because there are better options out there and we do endorse those.

from core.

I'm in favor of Kohana adopting the package, if @rjd22 continues to maintain it. I don't feel like having a package means we endorse anything, it just provides something more official to prevent fragmentation.

👍

from core.

@shadowhand I will continue maintaining it. Luckily @Ikke also uses it for a project.

from core.

@enov @shadowhand I think it would be a good idea to change the way we do versioning starting with this package.

We used to have a /develop and /master branch. I think mostly for submodule support.

Since we have releases support in github and composer I think it would make it easier to just only to have a master branch and let composer figure out what version of Kohana it will be compatible with.

I only use the config of Kohana anyway, the autoloading is done completely by composer. When you move you config file to the application folder you are able to use this module without adding it to your Kohana modules .

from core.

@rjd22 @acoulton @shadowhand

Besides adopting this module, we also need to add some users to the ORM module, so that they can maintain it.

from core.

@enov well it depends. Do we still want to promote the usage of the ORM module or do we want to deprecate it in favor for doctrine or a different ORM library?

If the later maybe we should drop development of it.

from core.

@enov @acoulton do you all agree to move the module into the kohana repository? So others can start using it?

from core.

👍

from core.

@rjd22 sure - we have a lighterweight version we've been using (ingenerator/kohana-doctrine2) and will probably stick with that in the immediate future as it works for us, but yours looks like a better candidate for being official.

Definitely having something so we can actively deprecate/drop kohana/orm would be good.

from core.

Imported the kohana doctrine module. I will fix the composer and travis later.

from core.

travis and composer fixed but I can't add it to packagist. @enov @acoulton @shadowhand do you know how to add it?

from core.

@rjd22 You probably need additional permissions from @shadowhand

from core.

If you have access to https://github.com/kohana/doctrine/settings/hooks/new?service=packagist then you should just be able to:

• Go to https://packagist.org/login and login with github - it doesn't really matter whose account is linked to the packagist project, apart from to match up the webhook API token IMHO
• Go to https://packagist.org/packages/submit and put in the repository URL
• Grab your packagist API token from https://packagist.org/profile/
• Set up the packagist webhook at https://github.com/kohana/doctrine/settings/hooks/new?service=packagist

If you don't have access to the kohana/doctrine settings then I guess you need to ask @shadowhand to do this, or to bump up your permissions on that repo.

Note you don't actually need permissions to add to packagist, just to set up the github webhook.

from core.

I think @shadowhand needs to do it. Packagist only allows maintainers to add packages to packagist.

from core.

@rjd22 anyone can submit to packagist and you have full admin on that repo. I've also added @acoulton as an admin.

from core.

@shadowhand I'm getting the following error when I'm trying to submit.

The vendor is already taken by someone else. You may ask them to add your package and give you maintainership access. The packages already in that vendor namespace can be found at kohana

from core.

Hm, that's new...

Looks like I can (I was already on as I maintainer of koharness) so I've submitted it and added you and @shadowhand as maintainers.

from core.

@acoulton thanks!

from core.

Closing this since it's now finished

from core.