Comments (9)
@ksooo this sounds like your area of expertise
from pvr.hts.
IMO two steps are needed for this
- ksooo@742cefc which I've created almost immediately after this feature was introduced in tvh but IIRC my tests ended up with the result that it was still buggy in tvh (at that time). I commented on the related tvh commits (tvheadend/tvheadend@c05a478#commitcomment-13537005) but never got feedback. Thus, I postponed this commit and did not PR it.
- Change Kodi core to handle disabled timers correctly, for instance here https://github.com/xbmc/xbmc/blob/master/xbmc/pvr/timers/PVRTimerInfoTag.h#L127
from pvr.hts.
On second thought, to solve the problem mentioned by @ProfYaffle only step 1 should be enough. Maybe step 2 is not needed at all.
@ProfYaffle maybe you can cherry-pick ksooo@742cefc and do some tests?
from pvr.hts.
@ksooo No promises, but I can take a look when I get a chance, sure. I've not built the addons from source before, but I'm sure I can cope.
I think the issue you mention is the same as I raised here, btw:
https://tvheadend.org/issues/3196
... apparently fixed (although I haven't tested) in tvheadend/tvheadend@868e648
from pvr.hts.
wrong button, mutter, mutter
from pvr.hts.
Okay, I had a look... and have simply dug myself into a hole!
It seems that I can't just clone/build your add-oneshot-timer-enable-support branch because that only builds against Kodi versions since the merge of the Series Recording Support (xbmc/xbmc@36ad006) - which Isengard doesn't have. So I'd need to rebuild and install Kodi to a later master version as well, which is likely to break something...
Backporting this to Isengard doesn't look trivial either given the number of changes and later code refactoring (e.g. to src/HTSPTypes.h).
Thoughts? I may have the wrong end of the stick or be missing something trivial, of course...
from pvr.hts.
You need a recent Kodi nightly build (Jarvis) and pvr.hts master. Backporting to Isengard is way to much effort.
from pvr.hts.
... which is what I feared.
<time passes>
Damn, that was harder than I expected...
Jarvis master built. pvr.hts cloned from add-oneshot-timer-enable-support, built and installed. Main Isengard installation not broken...
It would seem that it does indeed fix the issue... the recording events are now listed as 'inactive', and they don't show up on the main Confluence screen as the next recording(s) any more.
Thanks.
An aside... it's probably something I'm missing, however, and here probably isn't the right place anyway, but...
It's really hard to get a simple list of upcoming recordings with this Kodi/PVR combination, as you have to look through each individual rule to see if it's matched anything. Deselecting 'group timers' at least lists the events, but still lists all the enabled rules as well - even if they're not matching anything.
I'd have thought a flag or indicator on the 'group timers' view would be useful - to show that a rule has matched some events and thus is worth drilling into. And when the events aren't grouped by timer, then the timers (rules) themselves shouldn't really be shown, or should be shown separately (i.e. not on the same list). If you like, a "rules view" (with flags to say something's matched) vs an "events view".
Anyway, perhaps still a work in progress on master, or perhaps I've missed something entirely!
Cheers...
from pvr.hts.
It would seem that it does indeed fix the issue... the recording events are now listed as 'inactive', and they don't show up on the main Confluence screen as the next recording(s) any more.
Cool. Thanks for testing. I will PR the code later today.
from pvr.hts.
Related Issues (20)
- pvr.hts segfaults - kodi 20.0-ALPHA1 (19.90.701) Git:20220701-30fb576edd HOT 8
- Too many status messages after long inactivity time HOT 3
- Kodi 19.4 (Nvidia Shield Pro) Audio Stutter and Buffering with TVHeadend Addon HOT 4
- Selecting a different video decoder HOT 2
- Kodi 20 Beta 1 & Nightlies - EPG Flush/Crash HOT 2
- Channel switch times HOT 3
- Feature request: Force software decoding for hts streams HOT 2
- Season 0 shows up as season 2 HOT 3
- Choppy audio only on bluetooth
- [issue] GUI is blocked when starting any live channel in Kodi Nexus HOT 8
- Live TV Subtitles broken on Kodi 20 HOT 1
- Cannot save settings on appletv HOT 3
- Live TV HEVC streams not playing-Ubuntu 22.04 lts Kodi Nexus HOT 22
- listitem.size doesn't update in real time HOT 1
- Channel Groups/Tags not syncing between tvheadend and Kodi HOT 1
- Feature Request: Warn when creating an overlapping recording HOT 3
- Disconnect from TVHeadend server while playing piped mpd-stream with "demux read no data for at least 10 secs" HOT 6
- [tvOS] Addon settings not saved
- Live TV HEVC streams not playing-Libreelec Intel generic HOT 6
- cstdint needs to be included in HTSPVFS.h HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from pvr.hts.