Code Monkey home page Code Monkey logo

Comments (8)

Jalle19 avatar Jalle19 commented on July 21, 2024

I don't think it's necessary to add a dialog prompt for this, we should instead just not try to skip past the end. I don't know if this is an addon issue or a generic Kodi issue, @FernetMenta do you know?

from pvr.hts.

bas-t avatar bas-t commented on July 21, 2024

@Jalle19 You're right, not skipping past EOF is needed anyway. But reaching EOF, one way or the other, I'd still like a dialog prompt that allowes me to either just stop watching the recording or delete it.

Come to think of it, when reaching EOF while watching a recording via a nfs share, same thing happens. So I guess that if this request can be honoured, it should be done in kodi first. If afterwards you guys should need to address any related issues in pvr.hts...

Your thoughts?

from pvr.hts.

Jalle19 avatar Jalle19 commented on July 21, 2024

I'm very much against showing a dialog. If you want to stop playback, just press stop. Plus we don't show a dialog when skipping all the way forward in a live stream either.

from pvr.hts.

ksooo avatar ksooo commented on July 21, 2024

Same here. 👎 for a dialog - no matter whether this is pvr.hts or kodi "issue".

from pvr.hts.

bas-t avatar bas-t commented on July 21, 2024

I get that. What about not skipping past EOF?

from pvr.hts.

ksooo avatar ksooo commented on July 21, 2024

could be a kodi thing, not a pvr addon thing

It is a "kodi thing".

from pvr.hts.

Jalle19 avatar Jalle19 commented on July 21, 2024

I tested a patch that prohibits this but I can't make it stop playback even if I skip all the way to the end. What happens though is that Kodi's buffering mechanism fails and the playback is all blocky until you skip back 10 seconds or more.

from pvr.hts.

bas-t avatar bas-t commented on July 21, 2024

Thanks.

from pvr.hts.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.